Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Date:   Thu, 29 Jul 2021 04:01:28 +0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From:   yajun.deng@linux.dev
Message-ID: <177cd530dcb2c9f4d09a2b23fdbbc71a@linux.dev>
Subject: Re: [PATCH] Revert "net: Get rid of consume_skb when tracing is
 off"
To:     "Herbert Xu" <herbert@gondor.apana.org.au>
Cc:     davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
In-Reply-To: <20210728125248.GC2598@gondor.apana.org.au>
References: <20210728125248.GC2598@gondor.apana.org.au>
 <20210728035605.24510-1-yajun.deng@linux.dev>
Precedence: bulk

July 28, 2021 8:52 PM, "Herbert Xu" <herbert@gondor.apana.org.au> wrote:=
=0A=0A> On Wed, Jul 28, 2021 at 11:56:05AM +0800, Yajun Deng wrote:=0A> =
=0A>> This reverts commit be769db2f95861cc8c7c8fedcc71a8c39b803b10.=0A>> =
There is trace_kfree_skb() in kfree_skb(), the trace_kfree_skb() is=0A>> =
also a trace function.=0A>> =0A>> Fixes: be769db2f958 (net: Get rid of co=
nsume_skb when tracing is off)=0A>> Signed-off-by: Yajun Deng <yajun.deng=
@linux.dev>=0A> =0A> Please explain in more detail why your patch is need=
ed. As it=0A> stands I do not understand the reasoning.=0A> =0Aif we don'=
t define CONFIG_TRACEPOINTS, consume_skb() wolud called kfree_skb(), ther=
e have=0Atrace_kfree_skb() in kfree_skb(), the trace_kfree_skb() is also =
a trace function. So we=0Acan trace consume_skb() even if we don't define=
 CONFIG_TRACEPOINTS.=0AThis patch "net: Get rid of consume_skb when traci=
ng is off" does not seem to be effective.=0A=0A> Thanks,=0A> --=0A> Email=
: Herbert Xu <herbert@gondor.apana.org.au>=0A> Home Page: http://gondor.a=
pana.org.au/~herbert=0A> PGP Key: http://gondor.apana.org.au/~herbert/pub=
key.txt