Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Date:   Thu, 29 Jul 2021 04:10:33 +0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From:   yajun.deng@linux.dev
Message-ID: <fd3ffb7a52925b05455199039bbc32d2@linux.dev>
Subject: Re: [PATCH] Revert "net: Get rid of consume_skb when tracing is
 off"
To:     "Herbert Xu" <herbert@gondor.apana.org.au>
Cc:     davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
In-Reply-To: <20210729040303.GA7009@gondor.apana.org.au>
References: <20210729040303.GA7009@gondor.apana.org.au>
 <20210728125248.GC2598@gondor.apana.org.au>
 <20210728035605.24510-1-yajun.deng@linux.dev>
 <177cd530dcb2c9f4d09a2b23fdbbc71a@linux.dev>
Precedence: bulk

July 29, 2021 12:03 PM, "Herbert Xu" <herbert@gondor.apana.org.au> wrote:=
=0A=0A> On Thu, Jul 29, 2021 at 04:01:28AM +0000, yajun.deng@linux.dev wr=
ote:=0A> =0A>> if we don't define CONFIG_TRACEPOINTS, consume_skb() wolud=
 called kfree_skb(), there have=0A>> trace_kfree_skb() in kfree_skb(), th=
e trace_kfree_skb() is also a trace function. So we=0A>> can trace consum=
e_skb() even if we don't define CONFIG_TRACEPOINTS.=0A>> This patch "net:=
 Get rid of consume_skb when tracing is off" does not seem to be effectiv=
e.=0A> =0A> The point of my patch was to get rid of consume_skb because i=
ts=0A> only purpose is to provide extra information for tracing. If you'r=
e=0A> not tracing then you don't need that extra information (and overhea=
d).=0A> =0AOk, I didn't understand it well. =0A> Cheers,=0A> --=0A> Email=
: Herbert Xu <herbert@gondor.apana.org.au>=0A> Home Page: http://gondor.a=
pana.org.au/~herbert=0A> PGP Key: http://gondor.apana.org.au/~herbert/pub=
key.txt