Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 29 Jul 2021 07:40:30 +0200
User-Agent: K-9 Mail for Android
In-Reply-To: <CAJMQK-g8g5QJbBkU-A6th1VSWafxVv2fGtym+enQa_hDVaVoBw@mail.gmail.com>
References: <20210727174025.10552-1-linux@fw-web.de> <CAJMQK-g8g5QJbBkU-A6th1VSWafxVv2fGtym+enQa_hDVaVoBw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH] soc: mmsys: mediatek: add mask to mmsys routes
To:     Hsin-Yi Wang <hsinyi@chromium.org>
CC:     "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>, CK Hu <ck.hu@mediatek.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        lkml <linux-kernel@vger.kernel.org>, stable@vger.kernel.org,
        Frank Wunderlich <frank-w@public-files.de>
From:   Frank Wunderlich <linux@fw-web.de>
Message-ID: <97C4FA94-B28A-4F0E-9CD3-4E33B01BA353@fw-web.de>
Precedence: bulk

Am 29=2E Juli 2021 05:15:23 MESZ schrieb Hsin-Yi Wang <hsinyi@chromium=2Eor=
g>:

>This patch is breaking the mt8183 internal display=2E I think it's
>because  ~routes[i]=2Eval; is removed?
>Also what should the routes[i]=2Emask be if it's not set in
>mmsys_mt8183_routing_table?
>
>>                         writel_relaxed(reg, mmsys->regs +
>routes[i]=2Eaddr);
>>                 }
>>  }
><snip>

The mask should reset the needed bits,maybe it needs to be adjusted for yo=
ur ddp components=2E=2E=2E

Can you add some debugs inside loops in mtk_mmsys_ddp_connect and mtk_mmsy=
s_ddp_disconnect (show read val,mask and final mask before write) to show d=
ifferences before and after the patch?

regards Frank