Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 29 Jul 2021 07:53:58 +0200
User-Agent: K-9 Mail for Android
In-Reply-To: <CAJMQK-gQeMidjBZ1E=ReMmffC5G8oiFawB4Ey1PNb2ZWXw_1Bg@mail.gmail.com>
References: <20210727174025.10552-1-linux@fw-web.de> <CAJMQK-g8g5QJbBkU-A6th1VSWafxVv2fGtym+enQa_hDVaVoBw@mail.gmail.com> <97C4FA94-B28A-4F0E-9CD3-4E33B01BA353@fw-web.de> <CAJMQK-gQeMidjBZ1E=ReMmffC5G8oiFawB4Ey1PNb2ZWXw_1Bg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH] soc: mmsys: mediatek: add mask to mmsys routes
To:     Hsin-Yi Wang <hsinyi@chromium.org>
CC:     "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>, CK Hu <ck.hu@mediatek.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        lkml <linux-kernel@vger.kernel.org>, stable@vger.kernel.org,
        Frank Wunderlich <frank-w@public-files.de>
From:   Frank Wunderlich <linux@fw-web.de>
Message-ID: <6BFE13A3-6A42-455E-BDF7-CD285CC6C66D@fw-web.de>
Precedence: bulk

Am 29=2E Juli 2021 07:47:03 MESZ schrieb Hsin-Yi Wang <hsinyi@chromium=2Eor=
g>:
>On Thu, Jul 29, 2021 at 1:40 PM Frank Wunderlich <linux@fw-web=2Ede>
>wrote:
>>
>
>>
> struct mtk_mmsys_routes {
>         u32 from_comp;
>         u32 to_comp;
>         u32 addr;
> +       u32 mask;
>         u32 val;
>  };
>mask is not the last element, and mmsys_mt8183_routing_table =3D {
>  {
>    DDP_COMPONENT_OVL0, DDP_COMPONENT_OVL_2L0,
>    MT8183_DISP_OVL0_MOUT_EN, MT8183_OVL0_MOUT_EN_OVL0_2L
>  }
>=2E=2E=2E
>so the mask and val will be wrong=2E CK, do you know what mask we should
>set for mt8183? Or can we just set a dummy 0 mask=2E

Ahhh=2E=2E=2Emt8183 has own mmsys-table and
i had only changed the default one,so
value is now missing because value is now the mask=2E I have used same ord=
er as
CK to avoid confusion and make it easier
to review=2E
Afaik you could use same value as value to reset same bits=2E=2E=2Edid thi=
s in default routing table too=2E

regards Frank