Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 29 Jul 2021 07:54:23 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Ian Pilcher <arequipeno@gmail.com>
Cc:     linux-block@vger.kernel.org, linux-leds@vger.kernel.org,
        axboe@kernel.dk, linux-kernel@vger.kernel.org, pavel@ucw.cz,
        kernelnewbies@kernelnewbies.org
Subject: Re: [RFC PATCH 4/8] block: Add block class attributes to manage LED
 trigger list
Message-ID: <YQJCj/LjjCqb93AS@kroah.com>
References: <20210729015344.3366750-1-arequipeno@gmail.com>
 <20210729015344.3366750-5-arequipeno@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210729015344.3366750-5-arequipeno@gmail.com>
Precedence: bulk

On Wed, Jul 28, 2021 at 08:53:40PM -0500, Ian Pilcher wrote:
> * New class attributes - /sys/class/block/led_trigger_{new,list,del}
> 
> * Add init function - blk_ledtrig_init() - to create the attributes
>   in sysfs.  Call blk_ledtrig_init() from genhd_device_init() (in
>   block/genhd.c).
> 
> * New file - block/blk-ledtrig.h

That is an odd way to write a changelog, please read the documentation
file about how to write a good changelog.

thanks,

greg k-h