Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp5886553pxv; Thu, 29 Jul 2021 00:31:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwMG5OSvPchLqKyGoAEZBnyVtgiIkDRESVMBcepmlFmXj6cQj3nqPVRSoy2pZ2GG60lZRXv X-Received: by 2002:a05:6638:3a4:: with SMTP id z4mr3274282jap.65.1627543874814; Thu, 29 Jul 2021 00:31:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627543874; cv=none; d=google.com; s=arc-20160816; b=ZiQrwJWuzVkA8HzTXjL8nRQI2A3Y77IzKkxLW2dkeA6uzdc3dQXrm+YHPp+RiLp2Ap NMCvWw/8CxruxXly8WhnraPrNUmEpxp9UZMKnWZ2aSP9v8UcIi8cbPdTYCtGeJ3UmDRn 5Se37gMUKINb71soB+y7xN3adCWXfSNTr8gdkf1Se8JDRQy5Tg05yQ/WCcYD5gAQqrLI DFUkrfZal+96LjnBL/7hdkFU8ecQlGCnkepvYfG36Q2zYHUpcZBr+txMz9taOI6Oh72G RWAjyUA7u5EVPzLmk6uSU+aIGagKzWNLcsNMN3+Y/1HUksgglrvbSEApB2KWnr1YPPQM 7VjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=/+H+hlbxo12xXW1A0lhfylmepS5tW3r2f+yt4ocirug=; b=l0v0QAOdgGCnP4lL0JN2GA1n+WCwfKSy+NV1L6Tz8whvIkzWcZ0C5lBC1ZB32JKfie Cknskd2EX8xSodfit8f4aLbHi4Swa0qQ7hCG16qPsRJiSLbx11p7peEB0wVlfdsomA3A gmPwV1oqeSsRpUhHffwhUvurHqQBXpIIbzd3qiUBDd7ez8wCfzqWoDRVcwzS2t0aIBGU t8sQQpAVF6uhnsJq+VUFoNmh4I7Crg34TMHvEdhEcmYsRDRRYI+wGQ4PuIcengaJ22Da ejw7rBq40F3L181fbLHiDQYQTpEpk3IBnf4OmaHB8Cq7UXqtt2CpSytt0VBK0iMeLJsU vQmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b12si2522563jal.75.2021.07.29.00.31.03; Thu, 29 Jul 2021 00:31:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234317AbhG2H3p (ORCPT + 99 others); Thu, 29 Jul 2021 03:29:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234520AbhG2H3n (ORCPT ); Thu, 29 Jul 2021 03:29:43 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34E91C0613D3 for ; Thu, 29 Jul 2021 00:29:41 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m90U7-0000u8-F0; Thu, 29 Jul 2021 09:29:39 +0200 Received: from [2a0a:edc0:0:900:2e4d:54ff:fe67:bfa5] (helo=ginster) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1m90U6-0002Iy-F7; Thu, 29 Jul 2021 09:29:38 +0200 Received: from jbe by ginster with local (Exim 4.92) (envelope-from ) id 1m90U6-0002gi-EC; Thu, 29 Jul 2021 09:29:38 +0200 From: Juergen Borleis To: linux-mmc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, festevam@gmail.com, wsa+renesas@sang-engineering.com, dianders@chromium.org, ulf.hansson@linaro.org, kernel@pengutronix.de Subject: [PATCH 1/2] mmc: mxcmmc: really configure the DMA on demand Date: Thu, 29 Jul 2021 09:29:28 +0200 Message-Id: <20210729072929.10267-2-jbe@pengutronix.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210729072929.10267-1-jbe@pengutronix.de> References: <20210729072929.10267-1-jbe@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: jbe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Calling mxcmci_use_dma(host) is intended for the next transfer only, not for generic detection if DMA is possible. Without this change, the DMA gets never configured and thus, never used. Signed-off-by: Juergen Borleis --- drivers/mmc/host/mxcmmc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c index 2fe6fcd..611f827 100644 --- a/drivers/mmc/host/mxcmmc.c +++ b/drivers/mmc/host/mxcmmc.c @@ -834,7 +834,8 @@ static void mxcmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) else burstlen = 4; - if (mxcmci_use_dma(host) && burstlen != host->burstlen) { + if (host->dma != NULL && burstlen != host->burstlen) { + /* reconfigure DMA on changes only */ host->burstlen = burstlen; ret = mxcmci_setup_dma(mmc); if (ret) { -- 2.20.1