Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: rk3568-evb1-v10: add ethernet
 support
To:     Andrew Lunn <andrew@lunn.ch>, Peter Geis <pgwipeout@gmail.com>
Cc:     devicetree@vger.kernel.org,
        arm-mail-list <linux-arm-kernel@lists.infradead.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Heiko Stuebner <heiko@sntech.de>,
        Liang Chen <cl@rock-chips.com>, Simon Xue <xxm@rock-chips.com>
References: <20210728161020.3905-1-michael.riesch@wolfvision.net>
 <20210728161020.3905-3-michael.riesch@wolfvision.net>
 <YQGaAFvqqc7wXrWD@lunn.ch>
 <CAMdYzYo8zf0wjtAxTuYQnZQsBtw38prNuAA0j0sBEamcbzZbfA@mail.gmail.com>
 <YQHAHmMmysBVpF+m@lunn.ch>
From:   Michael Riesch <michael.riesch@wolfvision.net>
Organization: WolfVision GmbH
Message-ID: <a01e7faf-4cfc-dc04-44ea-2b1e0724778b@wolfvision.net>
Date:   Thu, 29 Jul 2021 11:07:50 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
In-Reply-To: <YQHAHmMmysBVpF+m@lunn.ch>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.100.125] (91.118.163.37) by AM6PR08CA0026.eurprd08.prod.outlook.com (2603:10a6:20b:c0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Thu, 29 Jul 2021 09:07:51 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e72ca8c5-32a5-40bc-c39b-08d95270582f
X-MS-TrafficTypeDiagnostic: DBAPR08MB5670:
X-Microsoft-Antispam-PRVS: <DBAPR08MB56702BF1C25651C100E33046F2EB9@DBAPR08MB5670.eurprd08.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Nby37xrPybM9HZYbqXoGKiXdtRFujjh0MUGS1kZQ0bU1uNgXcl5vnMj+HjUO2FE9TfIoM8Pis98taJmbUTXoKnYraEW6Um2VAbgdObEMHkcGxQFU7kw4t+n90sBTPs2CPNiql6imLk494u67rUTKau0hrvY2pIkj8ZpsSjRt8sDTHiRFdV8/TKUCWI8SggZU8VelRE9YZ49o4hVvx+vwUyPuUpRXBvzJTXLZd0SzhxGQXQoYdR2pll/lxKnD5QuKKrVljOdL1Y60L/8EAEk89I3BD56E+4CBKhcoEJmLv0vywAI8uFK1cwTeOdF2/GvVq5EUHOrmUgo1Wq6MPcaKqWnhh6RVN7Kyqc/UNTd3mtLphYlcVHEp+lPITrLI7e0TJ8JhGqMIWAUD9NCUA24R7ee9lsWCv2MKImJOlKAsWj1mRNZRjW5vfV2A/kBNwld3qQMifwQehbq4ULIKsvYe3uSgvm1ryARLAxhrVrJNCj9UwvQ7WdMke3ACsDndDJtTYrE+J85H0TmarYQS1aZSPLWAldfQ0tOb+im9ZIweviVHvjwSg1Pu+MJYcif37TIoJx/Xu688M/a38jJyT3V219r7xbJ/984RTDjV3zQ8UlcmlDb6KQXfzV/ifpj++XEFFRWCwwokxBx3HFY0HzPJpgH9r/RpjBJ2XLyMEBGJgojMMX34b/k7iwR+MQiRg6vPBxAvnGw2YrMWx3MqKAQYE02BCBFgiraPrXpeMpdMNjfl45WzsDsy/cbybgTqIniptzxYG3IAlELkS5zGGutUJg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DBBPR08MB4523.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(39840400004)(396003)(346002)(376002)(366004)(8676002)(2906002)(7416002)(66556008)(66476007)(8936002)(53546011)(2616005)(6486002)(956004)(36916002)(31686004)(52116002)(66946007)(86362001)(44832011)(36756003)(478600001)(110136005)(4744005)(38350700002)(38100700002)(4326008)(5660300002)(26005)(54906003)(186003)(31696002)(316002)(16576012)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WHV0MmVualRHZUVwVTlTdmtlVEpUMWw1RlNLM0ZTYkttaWJrRStGTlppVitU?=
 =?utf-8?B?VlVyYWdDU1kyY0xYeWh2cWg0cmVmaXZWdUc5eTQrRUR6Q3pPUXVnVndRS1RS?=
 =?utf-8?B?N2ZlSGZXdEczbjlJTHRkWERMQkJTY3hvRVAzK1M5V0orWGhCemltSkFicEJo?=
 =?utf-8?B?WEwxazV2R294c3h6N2dDNUZCaXZiM3lRRFZPMU95SFRIWjlETThXL0VvUUxR?=
 =?utf-8?B?L3VTMmIyM1VOK2NtQ0gySTMvTzBkRy9jQmhYSlBlNjBCOTEyTlFmMlVWeHNk?=
 =?utf-8?B?b29tVVhYZlB5YlRvQjltMkRrYzlBRmgrUWRUQVFYUFZvcEMxNnZ3VWN5SG9o?=
 =?utf-8?B?Z2ZreTNINmNveGNXWXhXVTNQVUhaWFArQURUemgwNTZPUVN3blowOHlCQzZC?=
 =?utf-8?B?MjUwV21oenZzcFcxNTJMZE1BajNTVEl5SnVJWFppVWFBa2VuR3JuTnNKZTZq?=
 =?utf-8?B?SEpDM0tRNWY2ajdxU24zQ1VzUGxrV1phdXBmaU13USs0RGY0eE9ZdkFvZlFl?=
 =?utf-8?B?aTJwdmFRZmRxVC9mUk1lTllrN0RIdm1wSHJhYzNIczcvQW5RcCtwMVVJQXZ2?=
 =?utf-8?B?RFNrVGJxYWpBQ2RoREVHSlp3QUcxYW5mUDNyU2t3bnEzVVhyY2J3RzY5SG41?=
 =?utf-8?B?cVloay9vZ3V0cEdpeTgrVkprUDNCYm5SWklXdXZ0TmtQcjU1MjR5eXd0a1JN?=
 =?utf-8?B?cDhzU2xCMkt1MTAxQmtYNnAzQWhJWHlxcFBYMndpbEFPZFMxYU9UWERQaDZW?=
 =?utf-8?B?TlVPZDlyTVhaTFdGdVVUdzBMVkxkTWxxR01QTzRhcVBxZzBXWUtiYmJmSWZF?=
 =?utf-8?B?VFgyTG8zZ05JRkIzMHNEdG9TVE1qZFRBWnQzTnhTYzludk40dUhlMXp5WXQ0?=
 =?utf-8?B?cXRBY2ZJSklveDIzbHNFeEo1cFU1SUlUR25RbEdYaDVmckxHWDRDQ09lVzAz?=
 =?utf-8?B?Uks3d003RnNUSkRUQTNoR2o5aGwxMkJNSXVYWEtDSC8xbG9udCtTOW95Skh3?=
 =?utf-8?B?N0ZNZTBLRENWRkdnclI5a28zdmowVCtmZ0w4ZkFjemNTU0lCTkUzR3lLSVk3?=
 =?utf-8?B?d29oV0I5YW1ESEpuTkpERE9vUHFvTXdjMTZIYitpSDBwS3AxaEtSaWpzelVE?=
 =?utf-8?B?dWtVb1dTOUN5TzU2K3NaOHh1ekMzc3hBalhnRXlwdlRzUzFvT1RDdFg5UHpO?=
 =?utf-8?B?c2QvU2t5Nyt6bVF4cW0vYlFtL2pRSjV2MnUrMCtLTHhRcitzUk4yTWZOa3Rw?=
 =?utf-8?B?MFM4YVRNTGcrVitTYkdvZUxmeVZjSmc1MGE1Z1ZYcU91VHl1cW16eG5HTjRP?=
 =?utf-8?B?cGp0cHo4NDhoWTFmTmxqMTVTblJuaVNuTDZsaTV2TzJNMTZ5bmRMQUZUbHhH?=
 =?utf-8?B?VlhvTlhIOVFjQys4czRPOTRodHVLVmtFZUYrMVQ0Y3YrTloyeG45WEFDdnUr?=
 =?utf-8?B?aFc2STQ3dGVyakxLVEcwQm52LzRIczN1eFpGR25VcFVtVFQ0VDdUNWNWSFJP?=
 =?utf-8?B?am9DR3FuVmxCVVpDSU14ek9tQThaQ3BBd3gva1M4dXlmdGttVzZVaXFXWUNk?=
 =?utf-8?B?OVVWRk9aZC94QkUwaXNzSDlMS3pqeVJ6a1h3RTlHWFhBKzhiQ0JVcEROZVMr?=
 =?utf-8?B?R3dPTWdrRTB0MnNqUHBWTzVMem0vaEgzdGJTOFRsdC9USjlBN2E0V2ludlN3?=
 =?utf-8?B?THB6WGVEN2xYcG1ScnRhTkY1VkU3NnJod3NIMGtHd3d1Y3IwdnhLalVySnRz?=
 =?utf-8?Q?x9v99CRGVwFUB9IXvEu9R0ElVmfwzzptXoyHGfn?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: e72ca8c5-32a5-40bc-c39b-08d95270582f
X-MS-Exchange-CrossTenant-AuthSource: DBBPR08MB4523.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2021 09:07:52.0614
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eg2xglsIdnwEDt8f9VJ0UsvpZI9bnAcdl6U7yq1YY5pzt+lsCTrDiugcFSPJ9oiqfQIyItUZboUmHrXPIMKlyxkP8dPFlZE7ppvB/05cCz4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5670
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Andrew, Peter,

On 7/28/21 10:37 PM, Andrew Lunn wrote:
>> Generally all rockchip boards use this value instead of the rgmii_id,
>> I imagine because it's more consistent to tune here than the hit or
>> miss support of the phy drivers.
> 
> Most PHY drivers actually implement it correctly, since by default,
> most systems get the PHY to do the delays.
> 
> But if most Rockchip boards do it this way, there is a lot to be said
> for consistence, so this is fine by me.

I have tested a dts without the delays and with phy-mode = "rgmii-id"
and it seems to work just fine.

Although consistency with other Rockchip boards is something one should
consider, I think I'll go along the "rgmii-id" path since this seems to
be a more general convention.

Thanks for your comments, I'll submit a v2.

Regards, Michael