Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210706114120.197-1-alistair@alistair23.me>
In-Reply-To: <20210706114120.197-1-alistair@alistair23.me>
From:   Alistair Francis <alistair23@gmail.com>
Date:   Thu, 29 Jul 2021 21:20:14 +1000
Message-ID: <CAKmqyKP8HKERLS3ckOA3wwpiv6J4tdFXn8-d6wXxDXDGn5iN=w@mail.gmail.com>
Subject: Re: [PATCH 1/2] regulator: sy7636a: Remove the poll_enable_time
To:     Alistair Francis <alistair@alistair23.me>
Cc:     lgirdwood@gmail.com, Mark Brown <broonie@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jul 6, 2021 at 9:41 PM Alistair Francis <alistair@alistair23.me> wrote:
>
> From testing on hardware the poll_enable_time isn't required and
> sometimes causes the driver probe to fail so let's remove it.
>
> Signed-off-by: Alistair Francis <alistair@alistair23.me>

Ping

AlistaIr

> ---
>  drivers/regulator/sy7636a-regulator.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/regulator/sy7636a-regulator.c b/drivers/regulator/sy7636a-regulator.c
> index e021ae08cbaa..c3b34cac8c7f 100644
> --- a/drivers/regulator/sy7636a-regulator.c
> +++ b/drivers/regulator/sy7636a-regulator.c
> @@ -13,8 +13,6 @@
>  #include <linux/gpio/consumer.h>
>  #include <linux/mfd/sy7636a.h>
>
> -#define SY7636A_POLL_ENABLED_TIME 500
> -
>  static int sy7636a_get_vcom_voltage_op(struct regulator_dev *rdev)
>  {
>         int ret;
> @@ -61,7 +59,6 @@ static const struct regulator_desc desc = {
>         .owner = THIS_MODULE,
>         .enable_reg = SY7636A_REG_OPERATION_MODE_CRL,
>         .enable_mask = SY7636A_OPERATION_MODE_CRL_ONOFF,
> -       .poll_enabled_time = SY7636A_POLL_ENABLED_TIME,
>         .regulators_node = of_match_ptr("regulators"),
>         .of_match = of_match_ptr("vcom"),
>  };
> --
> 2.31.1
>