Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp6019501pxv; Thu, 29 Jul 2021 04:34:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJybFgRXf9Yy5SXG4Q+Cz/7B6VRBfZm4ctUaeIJKou9Bir24bXBnbKNohKo8T5p6GBWCQut8 X-Received: by 2002:a50:d70a:: with SMTP id t10mr5416237edi.253.1627558473813; Thu, 29 Jul 2021 04:34:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627558473; cv=none; d=google.com; s=arc-20160816; b=lhghx6YSFY9jzN/Xo+s5WYiCpNv28XiK4X2JJhgaHMUYNWAx6sUh7SR/GDKtJ/zZvu RogBNXzUb8mPpQemTd09S+n/k2zn+eox+tTzutOWyt3r4aLLLm9APTpYaODMp/Tddzf9 KIRnxkmwNksSDTuqBRS84rU6QnhgGJW8GTzhFex4d1967hMNAqPVfNH9eGHWa/AyKx7L huon3/5GeBoat+8zQBLwsSaAQcYNoPb0CHFyQh1hHbpDaxpCmNKxRr8OxWtv0qmhtqxw l1QDZV/rbQfkNRFy9y6j0GHm/Rn7845ZKOpTZxliVBsW2kvohEub/CIpBn/xPbRKtWW1 W0mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:references:cc :to:from:subject; bh=rApdM6huJ0wjHqoL1D5DbaLIjC+CvEucuOcV2inYE44=; b=W7OYrFoeRcDG8JFx3KS7es6T5f+BchoeIKxY0cMsQCEyeCQh8bXEDmZOnR5GqTr8nM wew/ITdpbDeOK1DZ5sl7G62xHIDndaGlJEFrBarFV8Jhk5jxIHV1RURdxWkQT7EqXkhH RtsVfavU4gdTe48k+DzJstkwcDsoacPn8nzGqDR8iTBy2h/lvKjoiSWB4CujM1z95Oj1 NW7t27AJByfd7yQixpWdbIWSJlEj9sYvcmzr2XQ0gTJR/i13E1moGlnPQryAxKRWuLUr P3f+RbL1foKhddXxb4qnypYHv2O4mLUpWgEKylB+5Ke5sIs5wMcy97aUi4hmHLmFm8Ef d2Ew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t12si2582325eje.175.2021.07.29.04.34.10; Thu, 29 Jul 2021 04:34:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235607AbhG2Lcx (ORCPT + 99 others); Thu, 29 Jul 2021 07:32:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234161AbhG2Lcw (ORCPT ); Thu, 29 Jul 2021 07:32:52 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BC59C061765; Thu, 29 Jul 2021 04:32:46 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: gtucker) with ESMTPSA id 8FC731F43E41 Subject: Re: [PATCH] media: vivid: drop CONFIG_FB dependency From: Guillaume Tucker To: Hans Verkuil , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: Message-ID: <37aaf1b0-bb5a-a3df-054d-9aeea1f32a44@collabora.com> Date: Thu, 29 Jul 2021 12:32:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/07/2021 12:16, Guillaume Tucker wrote: > +ifeq ($(CONFIG_FB),y) > + vivid-objs += vivid-osd.o > +endif Just realised CONFIG_FB is tristate, so I guess it should be: ifneq ($(CONFIG_FB),) vivid-objs += vivid-osd.o endif Best wishes, Guillaume