Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 29 Jul 2021 14:44:42 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Marc Kleine-Budde <mkl@pengutronix.de>
Cc:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        wg@grandegger.com, davem@davemloft.net, kuba@kernel.org,
        angelo@kernel-space.org, linux-can@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] can: flexcan: Fix an uninitialized variable issue
Message-ID: <20210729114442.GT1931@kadam>
References: <a55780a2f4c8f1895b6bcbac4d3f8312b2731079.1627557857.git.christophe.jaillet@wanadoo.fr>
 <20210729113101.n5aucrwu56lyqhg7@pengutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210729113101.n5aucrwu56lyqhg7@pengutronix.de>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kadam (102.222.70.252) by JNAP275CA0022.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:4d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.21 via Frontend Transport; Thu, 29 Jul 2021 11:44:58 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6618d13e-4cc6-420c-a33f-08d952864fb8
X-MS-TrafficTypeDiagnostic: MWHPR10MB1549:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MWHPR10MB15499751F3C1CD64284A1C948EEB9@MWHPR10MB1549.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2331;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: clHsdlggNPCt7akXyY4SIT22lbWToa3JmXW9oT962jtUHxpt/c8JyLnNavIEpKCFIBMQhhlSCN3w9hBFJuIGWYD6R4COpyNDLYwWbk+Eu7Kc/NicFfqKnXxaLW8Ac/elSGAiJv0FOCR+9yJcyxJY96y7wQ5tCAHxklACh7wYwwLtj7wDlrXPTDmeqDUj61FgQ+BBIqkMl9SzWOzyF+VVsAQOTmxmgo1dXo57E/C03ax2Js0iDRJOeYA1SYG+vJZbPCAX3XKiql3QiT9RiotdHKtrSEXvcpcaB5AiDYrLAv69SoTFCqkRvfZ9MUcJBeF2u2VQFE+VzZQihBQ9qvE2NVPMC+Thj+HsOP/PACD53ZFl2yQg9y2xMgxsDHUEG8ZrAP28CDkm0wXVKRNHiBHr8y99/V3toZ368Yt5+SXVXOChIr+WOxVROt9mTzin3v46hxV+ZsDM16tGoSj5ZGLf9XkhqxczlCdbudzVrFuOi18mLkO6uN0gHuucB0vKLS11CBCzNForgpQZo1tav3/8/mumPEvSFEBrklKMXgE6e1m3CLMt5YjYXdOEtcM93amnRtvAPLrWoOEUqzfNWmdyUmS3Y+cnV7DqhrzY/JJ820tF3tODNfCXiz9tBgBwY2PCQZJ2VzNPVgBBv2ie4HJ1z7o0+0QBPoCdV4S1QzZJXqHSJkIzRRbLlhS1MufjNMPedkUYl5+2dqh8uX2ChvoZ+9WZIAl0/vIwbUbOpiY46EWLJ2cE5bkL6KPENWxnbl1ZsjueUXUZ/lby1X4Wx0FPygAM1LA8vJRhLk+uN0LUfN8=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(55016002)(6916009)(53546011)(8936002)(966005)(52116002)(8676002)(508600001)(86362001)(44832011)(83380400001)(9686003)(6496006)(956004)(33716001)(1076003)(26005)(7416002)(2906002)(9576002)(66946007)(66556008)(66476007)(38350700002)(38100700002)(4744005)(4326008)(5660300002)(6666004)(316002)(33656002)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zW4WzwFFzkbR1LF+IBc5QZ/nieIn1KbeHd/ZizPI693FNVtqS9cHMjei6aZg?=
 =?us-ascii?Q?eaFHWQ5m69wI2Vwt9ZImJvigohkBVQb6LpYlHOvfjI3Z47dG4wP//CT3CT0h?=
 =?us-ascii?Q?jpt+Qhof+CAdB74GruvdQfiwddO/QuIUjArCXW7WrfMV4FmBHY4jutU2XaYa?=
 =?us-ascii?Q?jJDkzzd7ZqtwLwHKL27sIbTkLKqfjvw+vzz56wWetf2bhETHvv9wnC1RIlnx?=
 =?us-ascii?Q?b2KRLKziSb8E28eYLCwX2TErNLDgNv4aajXGpFRSKDfVOt5cqnSrqU8rWSbV?=
 =?us-ascii?Q?mIAHSqa0s98fHVC098XTgywqjx5WP0PEuCphoYtb/d4D6k+Eqy4PvkFFF4pw?=
 =?us-ascii?Q?DkFwU6ajZZrays2EnfW0fNNc+3YjSaYAu5OlrE1One1PfwElZRRhmR/8zEw7?=
 =?us-ascii?Q?DI1lX0rOwtoMiP4QZvrrFOWAQ75w/CI7pXCHCa5J3bMPkfgRPi+CCOEnF+Wg?=
 =?us-ascii?Q?KpLRMqr+dRsf6lBvF7sY6csN2UkjKQXRRy8CoQpe2de2Tc0HWUHm7xBM+4NP?=
 =?us-ascii?Q?aEj/3nXYrEsKE9HuoB9zyzQdKM8gfqcNPr4NWHR2kQ3euduATBuiwSNQjpCk?=
 =?us-ascii?Q?1RCHiKpf1WZvQ3eFX53D3G8pVe0mfOkmApvwaqZIVwua7xWgDhEKA1Wbvs5H?=
 =?us-ascii?Q?tYcwxayAiEO5FXe5VpVtPb5FvhSARb/z3PtmX9uc6K7WVZEG1FIFxfKqnQ0P?=
 =?us-ascii?Q?GB+EUavV3ol+zDFohoTQPUeaN+QaDbcV5u4N5kTdArXyAIjN93DmEH53xhO6?=
 =?us-ascii?Q?KVdLiM9F2qNVEC1AJBTcDnteQqvwUITO3aqgnODrb2qACGArjhFhRtnJHJe0?=
 =?us-ascii?Q?So1L83ZFTorQlEEDtZwNbuKCzvw12x+R50crWr+CQ6Odnx/tRsX3+BWA+7iH?=
 =?us-ascii?Q?rGNWt+gB6xXMgho9By5eE/c5hmTO86+yY865HjjIn9q7kWg4M1ToB67xSvyd?=
 =?us-ascii?Q?qEqlMO8pVT745acDOZ8HNrsoAZt8mpP+/t4WbugC8Rs9HDOGwqcyQg1/HnzB?=
 =?us-ascii?Q?dGvzezvrxYLvTaaj42QIXPJAkioeOSRQaVmlyOgoeZxpZpLcKxmHSDvCTLud?=
 =?us-ascii?Q?ksOa7P6eJQHXzqF5U8uBX3cR8ixdBjKhKzdgY3Ru4gswsVJ7QI/vmaeyXMU1?=
 =?us-ascii?Q?9mXQssfOzph/uyc+qZuKirb+GpZ0OMKIayXuY92OEOpE/vULiY43f9u8gjl+?=
 =?us-ascii?Q?y45F+aCgE2XE5VbJuwm41fFfqQRRsss2AoDMxtRk3Mq8h7Tx9euWK9hebxl2?=
 =?us-ascii?Q?TLkKr9rkuHJzxGaMS9sYhYzujfUQhrACYL6C/DV9qlUh1VkEYi/cCukVjmBg?=
 =?us-ascii?Q?RrtacHDlb1lWiyoRA3Hb0LM6?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6618d13e-4cc6-420c-a33f-08d952864fb8
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2021 11:45:06.8380
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G+F6NP7ZJNEt7XPMvCfdTRfUF2B6w/7kov/+HTMnmT5oef0YlsuslTs4H2dd3A0dpXRNlO39btpRwuDC9o+55TVeYh16NiDlGHu3LTkb5xw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1549
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10059 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0
 suspectscore=0 phishscore=0 mlxscore=0 bulkscore=0 mlxlogscore=930
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2107140000 definitions=main-2107290075
X-Proofpoint-GUID: bAltNr3Jg931tHnoy6rpmeMv5AoMcJjN
X-Proofpoint-ORIG-GUID: bAltNr3Jg931tHnoy6rpmeMv5AoMcJjN
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 29, 2021 at 01:31:01PM +0200, Marc Kleine-Budde wrote:
> On 29.07.2021 13:27:42, Christophe JAILLET wrote:
> > If both 'clk_ipg' and 'clk_per' are NULL, we return an un-init value.
> > So set 'err' to 0, to return success in such a case.
> 
> Thanks for the patch, a similar one has been posted before:
> https://lore.kernel.org/linux-can/20210728075428.1493568-1-mkl@pengutronix.de/
> 
> > Fixes: d9cead75b1c6 ("can: flexcan: add mcf5441x support")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > ---
> > Another way to fix it is to remove the NULL checks for 'clk_ipg' and
> > 'clk_per' that been added in commit d9cead75b1c6.
> > 
> > They look useless to me because 'clk_prepare_enable()' returns 0 if it is
> > passed a NULL pointer.
> 
> ACK, while the common clock framework's clk_prepare_enable() can handle
> NULL pointers, the clock framework used on the mcf5441x doesn't.

Huh?  It looks like it just uses the regular stuff?

regards,
dan carpenter