Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] tpm: ibmvtpm: Avoid error message when process gets
 signal while waiting
To:     Jarkko Sakkinen <jarkko@kernel.org>
Cc:     Stefan Berger <stefanb@linux.vnet.ibm.com>, peterhuewe@gmx.de,
        jgg@ziepe.ca, linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org, Nayna Jain <nayna@linux.ibm.com>,
        George Wilson <gcwilson@linux.ibm.com>,
        Nageswara R Sastry <rnsastry@linux.ibm.com>
References: <20210712162505.205943-1-stefanb@linux.vnet.ibm.com>
 <20210727024225.swqy5ypcytsngpd6@kernel.org>
 <ad4011fb-fc1f-4019-9856-7d171db3255c@linux.ibm.com>
 <20210728215033.dhnekvksekalhcrn@kernel.org>
From:   Stefan Berger <stefanb@linux.ibm.com>
Message-ID: <2add3eac-916e-5072-f62d-23c65e23fb17@linux.ibm.com>
Date:   Thu, 29 Jul 2021 09:39:18 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
In-Reply-To: <20210728215033.dhnekvksekalhcrn@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Precedence: bulk


On 7/28/21 5:50 PM, Jarkko Sakkinen wrote:
> On Mon, Jul 26, 2021 at 11:00:51PM -0400, Stefan Berger wrote:
>> On 7/26/21 10:42 PM, Jarkko Sakkinen wrote:
>>> On Mon, Jul 12, 2021 at 12:25:05PM -0400, Stefan Berger wrote:
>>>> From: Stefan Berger <stefanb@linux.ibm.com>
>>>>
>>>> When rngd is run as root then lots of these types of message will appear
>>>> in the kernel log if the TPM has been configure to provide random bytes:
>>>>
>>>> [ 7406.275163] tpm tpm0: tpm_transmit: tpm_recv: error -4
>>>>
>>>> The issue is caused by the following call that is interrupted while
>>>> waiting for the TPM's response.
>>>>
>>>> sig = wait_event_interruptible(ibmvtpm->wq,
>>>>                                  !ibmvtpm->tpm_processing_cmd);
>>>>
>>>> The solution is to use wait_event() instead.
>>> Why?
>> So it becomes uninterruptible and these error messages go away.
> We do not want to make a process uninterruptible. That would prevent
> killing it.

I guess we'll have to go back to this one then: 
https://www.spinics.net/lists/linux-integrity/msg16741.html

    Stefan


>
> /Jarkko