Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] media: em28xx: add missing em28xx_close_extension
To:     Pavel Skripkin <paskripkin@gmail.com>
Cc:     mchehab@kernel.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        syzbot+a6969ef522a36d3344c9@syzkaller.appspotmail.com
References: <7df1705e-b2c7-ddfc-9cc5-582fb1a304e5@xs4all.nl>
 <20210721194307.12155-1-paskripkin@gmail.com>
 <3b1de658-ebf0-e45f-49ef-953e3467e7d4@xs4all.nl>
 <20210729154556.6e257405@gmail.com>
From:   Hans Verkuil <hverkuil@xs4all.nl>
Message-ID: <aa8b3e18-7903-9380-d0d6-2303d09110fe@xs4all.nl>
Date:   Thu, 29 Jul 2021 15:40:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210729154556.6e257405@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 29/07/2021 14:45, Pavel Skripkin wrote:
> On Thu, 29 Jul 2021 11:45:19 +0200
> Hans Verkuil <hverkuil@xs4all.nl> wrote:
> 
>> On 21/07/2021 21:43, Pavel Skripkin wrote:
>>> If em28xx dev has ->dev_next pointer, we need to delete dev_next
>>> list node from em28xx_extension_devlist on disconnect to avoid UAF
>>> bugs and corrupted list bugs, since driver frees this pointer on
>>> disconnect.
>>>
>>> Fixes: 1a23f81b7dc3 ("V4L/DVB (9979): em28xx: move usb probe code
>>> to a proper place") Reported-and-tested-by:
>>> syzbot+a6969ef522a36d3344c9@syzkaller.appspotmail.com
>>> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com> ---
>>>
>>> Changes in v2:
>>> 	Previous patch was completely broken. I've done some
>>> debugging again and found true root case of the reported bug.
>>>
>>> ---
>>>  drivers/media/usb/em28xx/em28xx-cards.c | 4 +++-
>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/media/usb/em28xx/em28xx-cards.c
>>> b/drivers/media/usb/em28xx/em28xx-cards.c index
>>> c1e0dccb7408..d56b040e1bd7 100644 ---
>>> a/drivers/media/usb/em28xx/em28xx-cards.c +++
>>> b/drivers/media/usb/em28xx/em28xx-cards.c @@ -4139,8 +4139,10 @@
>>> static void em28xx_usb_disconnect(struct usb_interface *intf) 
>>>  	em28xx_close_extension(dev);
>>>  
>>> -	if (dev->dev_next)
>>> +	if (dev->dev_next) {
>>>  		em28xx_release_resources(dev->dev_next);
>>> +		em28xx_close_extension(dev->dev_next);
>>
>> Wouldn't it be better to swap these two?
>>
>> That order is also used for em28xx_close_extension(dev) and
>> em28xx_release_resources(dev).
>>
>> You do need to store dev->dev_next in a temp variable, though.
>>
> 
> Hi, Hans!
> 
> I don't understand why I need to store dev->dev_next in a temp
> variable. I don't see code in em28xx_release_resources() or
> em28xx_close_extension() that zeroes this pointer.

Apologies for the confusion, just ignore that bit. I misunderstood
what dev_next was for.

So check if swapping these two lines passes syzbot, and then that's
the final version.

Regards,

	Hans

> 
> 
> 
> With regards,
> Pavel Skripkin
> 
>