Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp6127871pxv; Thu, 29 Jul 2021 07:10:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6cv2abQL4OqeZnyy6PgEqPL3z1XJBLARtpraZ1SeimnJVbjrDGGJ0dh48vf3CiSZmyM1x X-Received: by 2002:a92:dac9:: with SMTP id o9mr3779126ilq.124.1627567851558; Thu, 29 Jul 2021 07:10:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627567851; cv=none; d=google.com; s=arc-20160816; b=Dn6sc2/U8geVuN0zgL5OtmHvEmsnbyJd0CDnyHS0UbsT5NwD8AOxgDamJOiu0eQyAz N9rfScd5JoBxCbgzcd8lox3qNexvp0tcLhtW05/f8VAOpVEUVUGLpEO7ISA3YD0Zo6PL oFMk6HBNNukjROF/uREBA05Pc13IxtzJ/TjETWQw4Jywma02UOLOo22OXdLOsN64ReZF +h+3YoAldbpGXzxUQ+lMwPcQyBavJt1E6zCm2x/fwydBEHrcT6I/ElKhECeivWIHQ5/7 9xqK9a0Ypr5Te7w3Rna0h4+h2Nvq4CVBOrFnca14m2sL+pmfJT9wPW2ukxn/vzLSLwz5 gmBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=uRqv2wT7QEE1rImtKCK9SZxsvYr3VSp7BqCEl44nNHc=; b=T2hzipEU9bVvRVWUOD+m5t3tlR23WfMqIpcL2J29LSQgmc5KTsO9E2JT0YtIFSbUHu JjDCxcEhGFs+0yakrAAJUmOmosPznpD6y4ojkhC09HmVDf87SiIlpgq7loVUCUyMrFjG IA+VDgE2ymAJCgugjKbCNvMIlbKRNk1cFOdFqXLsinxibkx7F1Pf+U3Xdo/jNCpUZp0v MUCBYKhCr+CLbWRqpqk1gODMUkRydvpBJnB+IZBFDmr1IgOzvI2jCMyH5U3/fyEBmpt3 oeae85SFQDO1DQNGJ6u31Mg9UBGkLXUPvpV7NPoMmr5BUGyadPbRSLYA4ZnPBO9wfmns zKlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=fhvLuVkK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x25si3151670jaq.11.2021.07.29.07.10.40; Thu, 29 Jul 2021 07:10:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=fhvLuVkK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239012AbhG2OIV (ORCPT + 99 others); Thu, 29 Jul 2021 10:08:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:49148 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238226AbhG2OA3 (ORCPT ); Thu, 29 Jul 2021 10:00:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DA43F6108C; Thu, 29 Jul 2021 13:59:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627567185; bh=ehVN1lUmJP5gTZ3vI5IQKKSPb1DWaFucAs0vsktFrAg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fhvLuVkKGLhXJjumFnTY/RhT1AfWIrozlzTQ5d86QY/wogTpqmHjRPp4koOd9TVLh FT7AqTIOypF+RCwdc8T4gEAb0z3J58YP8MKqosfZrrz+oGgRBLiqaQAKMFFXScxdtO rRQHt5f7uDHZSUUMZN5QvnKi/S+0H/7GwhIrlcMI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Xu, Yanfei" , "Paul E. McKenney" , Sasha Levin Subject: [PATCH 5.13 09/22] rcu-tasks: Dont delete holdouts within trc_wait_for_one_reader() Date: Thu, 29 Jul 2021 15:54:40 +0200 Message-Id: <20210729135137.632633169@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210729135137.336097792@linuxfoundation.org> References: <20210729135137.336097792@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Paul E. McKenney [ Upstream commit a9ab9cce9367a2cc02a3c7eb57a004dc0b8f380d ] Invoking trc_del_holdout() from within trc_wait_for_one_reader() is only a performance optimization because the RCU Tasks Trace grace-period kthread will eventually do this within check_all_holdout_tasks_trace(). But it is not a particularly important performance optimization because it only applies to the grace-period kthread, of which there is but one. This commit therefore removes this invocation of trc_del_holdout() in favor of the one in check_all_holdout_tasks_trace() in the grace-period kthread. Reported-by: "Xu, Yanfei" Signed-off-by: Paul E. McKenney Signed-off-by: Sasha Levin --- kernel/rcu/tasks.h | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h index 71e9d625371a..fcef5f0c60b8 100644 --- a/kernel/rcu/tasks.h +++ b/kernel/rcu/tasks.h @@ -937,7 +937,6 @@ static void trc_wait_for_one_reader(struct task_struct *t, // The current task had better be in a quiescent state. if (t == current) { t->trc_reader_checked = true; - trc_del_holdout(t); WARN_ON_ONCE(t->trc_reader_nesting); return; } -- 2.30.2