Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 29 Jul 2021 14:07:05 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Vitaly Kuznetsov <vkuznets@redhat.com>
Cc:     Siddharth Chandrasekaran <sidcha@amazon.de>,
        Siddharth Chandrasekaran <sidcha.dev@gmail.com>,
        Liran Alon <liran@amazon.com>,
        Ioannis Aslanidis <iaslan@amazon.de>,
        linux-hyperv@vger.kernel.org, linux-arch@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
        Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] asm-generic/hyperv: Fix struct hv_message_header ordering
Message-ID: <20210729140705.wj5tokeq6lkxm2yy@liuwe-devbox-debian-v2>
References: <20210729133702.11383-1-sidcha@amazon.de>
 <87eebh9qhd.fsf@vitty.brq.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87eebh9qhd.fsf@vitty.brq.redhat.com>
Precedence: bulk

On Thu, Jul 29, 2021 at 03:52:46PM +0200, Vitaly Kuznetsov wrote:
> Siddharth Chandrasekaran <sidcha@amazon.de> writes:
> 
> > According to Hyper-V TLFS Version 6.0b, struct hv_message_header members
> > should be defined in the order:
> >
> > 	message_type, reserved, message_flags, payload_size
> >
> > but we have it defined in the order:
> >
> > 	message_type, payload_size, message_flags, reserved
> >
> > that is, the payload_size and reserved members swapped. 
> 
> Indeed,
> 
> typedef struct
> {
> 	HV_MESSAGE_TYPE MessageType;
> 	UINT16 Reserved;
> 	HV_MESSAGE_FLAGS MessageFlags;
> 	UINT8 PayloadSize;
> 	union
> 	{
> 		UINT64 OriginationId;
> 		HV_PARTITION_ID Sender;
> 		HV_PORT_ID Port;
> 	};
> } HV_MESSAGE_HEADER;

Well. I think TLFS is wrong. Let me ask around.

Wei.