Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp6151905pxv; Thu, 29 Jul 2021 07:42:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVhNP+ZWI3ELfNUNZsuWt2SR4dTkmvFvFnNNKJRCBKyUwNxBFUo+aY4rfOU5HoxILywsYN X-Received: by 2002:a05:6e02:1b88:: with SMTP id h8mr3897135ili.48.1627569742397; Thu, 29 Jul 2021 07:42:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627569742; cv=none; d=google.com; s=arc-20160816; b=N69mDYhxozeYmWRMymS6EWfHrsHawxa4WINcqXMMTDWJCkLhLyc5aihuvgyyIYVh91 B2TP3+ubKLBXd+7BNY9KonbVMXQKT6YgwxfgYcvVDbaQa8HhNz5ZTjtH1kMboCfDKQf4 eLfAMGHstaSU+u82K4lTd3v56DUt4Lj/BO23IPIUdMdLTqrFgDw7Fn1r1K7CFqFN7hns jOcCVQXmP/W9L4PaQPiYlkj/pounOPjVqZYIOAdQamzUpzpZg62aRzMUTqbrXUOIMIZp +piAyLaHv8oLwNAemWmwlcgEqHGctup2x/8LpkeA3zg83bfMtGQbMJDpcLAT9QTklIB6 uRFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=g5bAj8ty5oGdKwNlb8K8CLCbwch75jyi8lukuavge1w=; b=WobZ4nWU3Mz43j9i2mG136oGpVaeI9xyUlSf1wXQR6iM1W9qKqfigr/cRlmTK218x6 Nd45/2Wx+lSYJiiYhvqzzwE+55WQ3rVP/6m3VPBNE/zsbTKHaYAXM1h+2IfgDHEcQFc6 fkaYlP4aUwaG81ZBc/Mg/HkIosW6GJiesBeAWi+auaXQN/Lfl89brB5f4ODC190F+osd QMZlh2hkAXG4HmGwrlbbpSMb641kTEhvt3FEom5NVOht0gzO7hpznYJI5tiwGYjDjIov TBXYbgpFUMEasaXKx6SIG1rGPTY28aZyCvMf24tsyUOavpivDj3ng+OSIsD9Muq5Eiib PWaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="Pt/myiUc"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e16si3772459ils.75.2021.07.29.07.42.09; Thu, 29 Jul 2021 07:42:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="Pt/myiUc"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237518AbhG2Okw (ORCPT + 99 others); Thu, 29 Jul 2021 10:40:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237295AbhG2Okv (ORCPT ); Thu, 29 Jul 2021 10:40:51 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1B43C061765 for ; Thu, 29 Jul 2021 07:40:47 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id n6so7827562ljp.9 for ; Thu, 29 Jul 2021 07:40:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g5bAj8ty5oGdKwNlb8K8CLCbwch75jyi8lukuavge1w=; b=Pt/myiUcp/HcWkRJqwMsshxtVCmbTMQkOHiiYTWtRrlpIQtfIwP/TshXg/Sv8sShX9 o2MFa/ULWHD9UC3jmOcqn1lmGxaT4wKLBTj9EmJNBAHOi7Q8KcOqOF0BKQN7ZPWxNCSJ XetW0whmTlm+G5aufSYRe0G9VUSjiNZ+WQeflOuu8nWflrnK9K1ff6Rd2RAu58nxE+Y6 7qbJdt29eO3qn86prpYrCpSIiyM4hC29igxet+IGxGq7kaFkObrd4BxwXuAznFdcDM9l 95jP6Xt6Saju2kAdhuCdAVe/F79H2aNR8AMySTMNEDU2FRE0HLzx6Q07o0jseAYwQdQb 9Rcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g5bAj8ty5oGdKwNlb8K8CLCbwch75jyi8lukuavge1w=; b=QKkcVTQ348zEngeoJbCWLZNgHGQBqDdOKLS240W4YH6LU5GQ4IagjxcoqYXo5p8Q3u rvYw4vCK7qV/mauzdhiPmjsvhqEfd30U0Rz1oQ5F9lbXMEKmsv5i9qBsEBABRf3UnZAS JcIMgSd71EcCkekqazzGGwVAVzxXpdKrlKtGS+Gnwp4RAeij8vc04ugQJTVf+FnPOgkY k1XMMvUh5sXZVbnrhwHaU6JbqK8RN5wjtVpg1+F4FzVHuzrtUaPYe/SjBPsAbr6OU5On ZlDHmAxG4NtPFKvrB7L98S3wLb8ycwT+Nf/enGJa+m/Q5Y3AgaFhDuYsP5jqYVx1P03M I82w== X-Gm-Message-State: AOAM53160JmYCkuMuzn5r34/rpQBNBGuhndIuHYYxRaIZAvrkJAz/Spe slhYLgN+yvAnrZ9qsqrRBr3Z9BT5Dwvzv4KRdjzauA== X-Received: by 2002:a05:651c:1211:: with SMTP id i17mr3201903lja.122.1627569645751; Thu, 29 Jul 2021 07:40:45 -0700 (PDT) MIME-Version: 1.0 References: <20210729125755.16871-1-linmiaohe@huawei.com> <20210729125755.16871-4-linmiaohe@huawei.com> In-Reply-To: <20210729125755.16871-4-linmiaohe@huawei.com> From: Shakeel Butt Date: Thu, 29 Jul 2021 07:40:34 -0700 Message-ID: Subject: Re: [PATCH 3/5] mm, memcg: save some atomic ops when flush is already true To: Miaohe Lin Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Roman Gushchin , Matthew Wilcox , alexs@kernel.org, Wei Yang , Muchun Song , Linux MM , LKML , Cgroups Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 29, 2021 at 5:58 AM Miaohe Lin wrote: > > Add 'else' to save some atomic ops in obj_stock_flush_required() when > flush is already true. No functional change intended here. > > Signed-off-by: Miaohe Lin Reviewed-by: Shakeel Butt