Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210729142811.1309391-1-hca@linux.ibm.com>
In-Reply-To: <20210729142811.1309391-1-hca@linux.ibm.com>
From:   Marco Elver <elver@google.com>
Date:   Thu, 29 Jul 2021 16:53:10 +0200
Message-ID: <CANpmjNM=rSFwmJCEq6gxHZBdYKVZas4rbnd2gk8GCAEjiJ_5UQ@mail.gmail.com>
Subject: Re: [PATCH] kcsan: use u64 instead of cycles_t
To:     Heiko Carstens <hca@linux.ibm.com>,
        "Paul E. McKenney" <paulmck@kernel.org>
Cc:     Ilya Leoshkevich <iii@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>, kasan-dev@googlegroups.com,
        linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

+Cc: Paul

On Thu, 29 Jul 2021 at 16:28, Heiko Carstens <hca@linux.ibm.com> wrote:
>
> cycles_t has a different type across architectures: unsigned int,
> unsinged long, or unsigned long long. Depending on architecture this
> will generate this warning:
>
> kernel/kcsan/debugfs.c: In function =E2=80=98microbenchmark=E2=80=99:
> ./include/linux/kern_levels.h:5:25: warning: format =E2=80=98%llu=E2=80=
=99 expects argument of type =E2=80=98long long unsigned int=E2=80=99, but =
argument 3 has type =E2=80=98cycles_t=E2=80=99 {aka =E2=80=98long unsigned =
int=E2=80=99} [-Wformat=3D]
>
> To avoid this simple change the type of cycle to u64 in
> microbenchmark(), since u64 is of type unsigned long long for all
> architectures.
>
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>

Acked-by: Marco Elver <elver@google.com>

Do you have a series adding KCSAN support for s390, i.e. would you
like to keep it together with those changes?

Otherwise this would go the usual route through Paul's -rcu tree.

Thanks,
-- Marco

> ---
>  kernel/kcsan/debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/kcsan/debugfs.c b/kernel/kcsan/debugfs.c
> index e65de172ccf7..1d1d1b0e4248 100644
> --- a/kernel/kcsan/debugfs.c
> +++ b/kernel/kcsan/debugfs.c
> @@ -64,7 +64,7 @@ static noinline void microbenchmark(unsigned long iters=
)
>  {
>         const struct kcsan_ctx ctx_save =3D current->kcsan_ctx;
>         const bool was_enabled =3D READ_ONCE(kcsan_enabled);
> -       cycles_t cycles;
> +       u64 cycles;
>
>         /* We may have been called from an atomic region; reset context. =
*/
>         memset(&current->kcsan_ctx, 0, sizeof(current->kcsan_ctx));
> --
> 2.25.1
>
> --
> You received this message because you are subscribed to the Google Groups=
 "kasan-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an=
 email to kasan-dev+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgi=
d/kasan-dev/20210729142811.1309391-1-hca%40linux.ibm.com.