Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp6204245pxv; Thu, 29 Jul 2021 08:50:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwcbWaxTRTSQkgCy+TwEPQ1SnjH4Vp00Ey+hZX88LbgYpCzTY10GRkOj7lTKoiGMUjf6ygH X-Received: by 2002:a05:6602:228d:: with SMTP id d13mr4682574iod.36.1627573829321; Thu, 29 Jul 2021 08:50:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627573829; cv=none; d=google.com; s=arc-20160816; b=domV1QEGWqYHiPYAFewKra+TnSqPV2RjTABC0V0LkbzMBoMgBtfK7YlH32p6z2VJC+ UpX2iyhHfFUUANkrSTLiDneQQyn0hrrrlwbK5sWNqYOe3LUKD80XLn2y37rWYc3ApGIu udoQyRmvxcs3eJP1wWNkKte7PlZIPhzaoDxjZRjscJaSULxsQdDY1EmCpdvG+CcpvYId l3mWii08S+DpxofXe7x4QSRnWvLPoCLVpBcIjCct9SHHcVhxPgQ6+AUJZm0XVtLkX8q+ jkRN5twUfeEw+yUlKjo0y0sKzHOhXAKBqUyhRh706tsadYAZ45P2B7GTqDHkpQp72EkP 8HhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature:dkim-signature; bh=BGETejjFkZtLsLCQCyIcbXPBMg4J1wjpmMhMDKVQqCY=; b=Z/nj1bkjJEDRU2HzygyGz2oMwgx+rYbr89RE+uZPEUUh3cbrdl4WITGedMitb6Z0nd 7Ugq63Dc0+7TXWnInSaWnWTWdiQ9QDk7aNxbrFdkGq/cDg5PYUipE2+X2DAn0hWIpGZ/ xiBwG4Ir9l8I1xadF270d0iFeIB3Amu7G4fY08E7r9tiet0DGuFnFE6VmA4m1REyM02G DaQ4vsiYj9nH6294oRWKSP9MOcv6pWafgt8y1Kwi3SDv70jIydDs3fmkYJN6ngT0dlVt G6OnHM/wjwTDbL72OIroEr+vu0jXJ8FbdAZ1szi4VPFtTBzCHIo/tWfRrSbya7ko+MIq Z8uA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=GPHZ5YAD; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h12si4198312ild.123.2021.07.29.08.50.15; Thu, 29 Jul 2021 08:50:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=GPHZ5YAD; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237891AbhG2PrZ (ORCPT + 99 others); Thu, 29 Jul 2021 11:47:25 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:60102 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229602AbhG2PrY (ORCPT ); Thu, 29 Jul 2021 11:47:24 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 75DC920057; Thu, 29 Jul 2021 15:47:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1627573640; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BGETejjFkZtLsLCQCyIcbXPBMg4J1wjpmMhMDKVQqCY=; b=GPHZ5YADFHOGSHkdeeuWFFrOcqJXVm56o4u/Tj19A5t+18BMepw/rA1Rxos8c7VQru0TCe EkqTNpH8lIG/cF6JECoki9jcI14u/GBNNN3UeOW7u79qkXOw9LGsWE+7H/y78wEZDKWRha 8sIcA5pX6GRSyrEN2zetsDXS/Qa+KtM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1627573640; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BGETejjFkZtLsLCQCyIcbXPBMg4J1wjpmMhMDKVQqCY=; b=KiKIixyRnw4jXrulQ/55BF7NfzU20dTCugzlQRV6eP6V85fmEFUOg4vCFPOeAA5aUnTLlY CENCxqaZAAH/mYBQ== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 490B3136BF; Thu, 29 Jul 2021 15:47:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id VcccEYjNAmEaNAAAGKfGzw (envelope-from ); Thu, 29 Jul 2021 15:47:20 +0000 Subject: Re: [PATCH v3 00/35] SLUB: reduce irq disabled scope and make it RT compatible To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim Cc: Mike Galbraith , Sebastian Andrzej Siewior , Thomas Gleixner , Mel Gorman , Jesper Dangaard Brouer , Jann Horn References: <20210729132132.19691-1-vbabka@suse.cz> From: Vlastimil Babka Message-ID: <7ce60b82-a8c5-f31c-b344-b214a6ca38f8@suse.cz> Date: Thu, 29 Jul 2021 17:47:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210729132132.19691-1-vbabka@suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/29/21 3:20 PM, Vlastimil Babka wrote: > Changes since v2 [5]: > * Rebase to 5.14-rc3 > * A number of fixes to the RT parts, big thanks to Mike Galbraith for testing > and debugging! > * The largest fix is to protect kmem_cache_cpu->partial by local_lock instead > of cmpxchg tricks, which are insufficient on RT. To avoid divergence > between RT and !RT, just do it everywhere. Affected mainly patch 25 and a > new patch 33. This also addresses a theoretical race raised earlier by Jann > Horn. > * Smaller fixes reported by Sebastian Andrzej Siewior and Cyrill Gorcunov > > Changes since RFC v1 [1]: > * Addressed feedback from Christoph and Mel, added their acks. > * Finished RT conversion, adopting 2 patches from the RT tree. > * The local_lock conversion has to sacrifice lockless fathpaths on PREEMPT_RT > * Added some more cleanup patches to the front. > > This series was initially inspired by Mel's pcplist local_lock rewrite, and > also interest to better understand SLUB's locking and the new primitives and RT > variants and implications. It should make SLUB more preemption-friendly, > especially for RT, hopefully without noticeable regressions, as the fast paths > are not affected. > > Series is based on 5.14-rc3 and also available as a git branch: > https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/linux.git/log/?h=slub-local-lock-v3r1 Branch with fixed memory leak in patch 33: https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/linux.git/log/?h=slub-local-lock-v3r2