Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Vineeth Pillai <viremana@linux.microsoft.com>
Cc:     Dan Carpenter <dan.carpenter@oracle.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        Vitaly Kuznetsov <vkuznets@redhat.com>
References: <20210726165843.1441132-1-pbonzini@redhat.com>
 <87zgu76ary.fsf@vitty.brq.redhat.com>
 <1d82501c-05fd-deff-9652-790cde052644@linux.microsoft.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] KVM: SVM: delay svm_vcpu_init_msrpm after svm->vmcb is
 initialized
Message-ID: <38eb919c-2da1-648e-10a4-a76205fd5e96@redhat.com>
Date:   Thu, 29 Jul 2021 18:30:49 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <1d82501c-05fd-deff-9652-790cde052644@linux.microsoft.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 28/07/21 22:18, Vineeth Pillai wrote:
> 
> On 7/27/2021 11:23 AM, Vitaly Kuznetsov wrote:
>> Paolo Bonzini <pbonzini@redhat.com> writes:
>>
>>> Right now, svm_hv_vmcb_dirty_nested_enlightenments has an incorrect
>>> dereference of vmcb->control.reserved_sw before the vmcb is checked
>>> for being non-NULL.  The compiler is usually sinking the dereference
>>> after the check; instead of doing this ourselves in the source,
>>> ensure that svm_hv_vmcb_dirty_nested_enlightenments is only called
>>> with a non-NULL VMCB.
>>>
>>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>>> Cc: Vineeth Pillai <viremana@linux.microsoft.com>
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>> [Untested for now due to issues with my AMD machine. - Paolo]
> Finally got hold of an AMD machine and tested nested virt: windows on 
> linux on
> windows with the patches applied. Did basic boot and minimal verification.
> 
> Tested-by: Vineeth Pillai <viremana@linux.microsoft.com>

Thanks!  In the meanwhile I had fixed my machine too. :)

Paolo