Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210729092831.38106-1-ligang.bdlg@bytedance.com>
In-Reply-To: <20210729092831.38106-1-ligang.bdlg@bytedance.com>
From:   Axel Rasmussen <axelrasmussen@google.com>
Date:   Thu, 29 Jul 2021 10:25:16 -0700
Message-ID: <CAJHvVchhhUXyi2YbaqMW53y=bT50kmOBjjbApaMG8QZPQ=h1OQ@mail.gmail.com>
Subject: Re: [PATCH 1/3] mm: mmap_lock: remove redundant "\n" in TP_printk
To:     Gang Li <ligang.bdlg@bytedance.com>
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux MM <linux-mm@kvack.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Reviewed-by: Axel Rasmussen <axelrasmussen@google.com>

On Thu, Jul 29, 2021 at 2:28 AM Gang Li <ligang.bdlg@bytedance.com> wrote:
>
> Ftrace core will add "\n" automatically on print. "\n" in TP_printk
> will create blank line, so remove it.
>
> Signed-off-by: Gang Li <ligang.bdlg@bytedance.com>
> ---
>  include/trace/events/mmap_lock.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/trace/events/mmap_lock.h b/include/trace/events/mmap_lock.h
> index 0abff67b96f0..5f980c92e3e9 100644
> --- a/include/trace/events/mmap_lock.h
> +++ b/include/trace/events/mmap_lock.h
> @@ -32,7 +32,7 @@ TRACE_EVENT_FN(mmap_lock_start_locking,
>         ),
>
>         TP_printk(
> -               "mm=%p memcg_path=%s write=%s\n",
> +               "mm=%p memcg_path=%s write=%s",
>                 __entry->mm,
>                 __get_str(memcg_path),
>                 __entry->write ? "true" : "false"
> @@ -63,7 +63,7 @@ TRACE_EVENT_FN(mmap_lock_acquire_returned,
>         ),
>
>         TP_printk(
> -               "mm=%p memcg_path=%s write=%s success=%s\n",
> +               "mm=%p memcg_path=%s write=%s success=%s",
>                 __entry->mm,
>                 __get_str(memcg_path),
>                 __entry->write ? "true" : "false",
> @@ -92,7 +92,7 @@ TRACE_EVENT_FN(mmap_lock_released,
>         ),
>
>         TP_printk(
> -               "mm=%p memcg_path=%s write=%s\n",
> +               "mm=%p memcg_path=%s write=%s",
>                 __entry->mm,
>                 __get_str(memcg_path),
>                 __entry->write ? "true" : "false"
> --
> 2.20.1
>