Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <a4rEWQfScKM8Y0B7u0NXSAdvKC6Xzesp1OWGUYjeWaA@cp3-web-016.plabs.ch>
 <20210728171807.GA1269122@robh.at.kernel.org> <yp8UA_I1d4WXcVkLUE7V6sKBGPOzNwpbmKl0UTzLxvyt-l-AgpNKvFcN038I7DDQB8qx8yOnE3OiUlzLrBqY-KY7Yub2FWWRosPmFsu_1jc=@protonmail.com>
In-Reply-To: <yp8UA_I1d4WXcVkLUE7V6sKBGPOzNwpbmKl0UTzLxvyt-l-AgpNKvFcN038I7DDQB8qx8yOnE3OiUlzLrBqY-KY7Yub2FWWRosPmFsu_1jc=@protonmail.com>
From:   Rob Herring <robh@kernel.org>
Date:   Thu, 29 Jul 2021 12:51:42 -0600
Message-ID: <CAL_JsqLNqKOs0WZvBF5L45VZu2OWtjxGyLoMCP-mGA3KbUVxOw@mail.gmail.com>
Subject: Re: [PATCH v2 3/3] dt-bindings: extcon: usbc-tusb320: Add TUSB320L
 compatible string
To:     Yassine Oudjana <y.oudjana@protonmail.com>
Cc:     Michael Auchter <michael.auchter@ni.com>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jul 28, 2021 at 11:33 AM Yassine Oudjana
<y.oudjana@protonmail.com> wrote:
>
> On Wednesday, July 28th, 2021 at 9:18 PM, Rob Herring <robh@kernel.org> wrote:
>
> > On Tue, 27 Jul 2021 09:57:15 +0000, Yassine Oudjana wrote:
> >
> > > Add a compatible string for TUSB320L.
> > >
> > > Signed-off-by: Yassine Oudjana y.oudjana@protonmail.com
> > > -------------------------------------------------------
> > >
> > > .../devicetree/bindings/extcon/extcon-usbc-tusb320.yaml | 4 +++-
> > >
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > Please add Acked-by/Reviewed-by tags when posting new versions. However,
> >
> > there's no need to repost patches only to add the tags. The upstream
> >
> > maintainer will do that for acks received on the version they apply.
> >
> > If a tag was not added on purpose, please state why and what changed.
>
> I changed indentation in this version to fix a dt_binding_check warning:
> ../Documentation/devicetree/bindings/extcon/extcon-usbc-tusb320.yaml:15:6: [warning] wrong indentation: expected 6 but found 5 (indentation)

That's certainly small enough change to keep any tag.

> I wasn't sure if I had to state changes in each individual patch, so
> I ended up only stating them in the cover letter:
> https://lore.kernel.org/lkml/a1IcsWeSdRxWaMFcwV1k7z3l1HaAkyRCo2zLdOWb8w@cp4-web-014.plabs.ch/

It is best to put the changes for specific patches in that patch and
use the cover letter as a summary of changes.

Rob