Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] media: vivid: drop CONFIG_FB dependency
From:   Guillaume Tucker <guillaume.tucker@collabora.com>
To:     Hans Verkuil <hverkuil@xs4all.nl>,
        Mauro Carvalho Chehab <mchehab@kernel.org>
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel@collabora.com
References: <bf74a4670438864ca2e6bde47121554490350729.1627557341.git.guillaume.tucker@collabora.com>
 <37aaf1b0-bb5a-a3df-054d-9aeea1f32a44@collabora.com>
Message-ID: <5a6270fd-57a5-e3f0-5485-1c514493d659@collabora.com>
Date:   Thu, 29 Jul 2021 19:53:33 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <37aaf1b0-bb5a-a3df-054d-9aeea1f32a44@collabora.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 29/07/2021 12:32, Guillaume Tucker wrote:
> On 29/07/2021 12:16, Guillaume Tucker wrote:
>> +ifeq ($(CONFIG_FB),y)
>> +  vivid-objs += vivid-osd.o
>> +endif
> 
> Just realised CONFIG_FB is tristate, so I guess it should be:
> 
> ifneq ($(CONFIG_FB),)
>   vivid-objs += vivid-osd.o
> endif

Tested-by: "kernelci.org bot" <bot@kernelci.org>

  https://staging.kernelci.org/test/job/gtucker/branch/for-kernelci/kernel/v5.14-rc3-4412-g964fed94b566/plan/v4l2-compliance-vivid/

with the change mentioned above, on top of next-20210729.

Best wishes,
Guillaume