Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935219AbWKZAp3 (ORCPT ); Sat, 25 Nov 2006 19:45:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S935218AbWKZAp2 (ORCPT ); Sat, 25 Nov 2006 19:45:28 -0500 Received: from smtp.osdl.org ([65.172.181.25]:55195 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S935213AbWKZApT (ORCPT ); Sat, 25 Nov 2006 19:45:19 -0500 Date: Sat, 25 Nov 2006 16:41:18 -0800 From: Andrew Morton To: Roland Dreier Cc: David Miller , linux-kernel@vger.kernel.org, openib-general@openib.org, tom@opengridcomputing.com Subject: Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro Message-Id: <20061125164118.de53d1cf.akpm@osdl.org> In-Reply-To: References: <20061124.220746.57445336.davem@davemloft.net> <20061125.150500.14841768.davem@davemloft.net> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 661 Lines: 17 On Sat, 25 Nov 2006 15:09:38 -0800 Roland Dreier wrote: > > But yes, given the array sizing case in the neighbour code, > > perhaps we can use your original patch for now. Feel free > > to push that to Linus. > > akpm is CC'ed on this thread. Andrew, are you going to pick this up? Changes this late in the piece rather hurt. Your proposed change is still wrong for long longs, isn't it? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/