To: Al Viro <viro@ftp.linux.org.uk>
Cc: David Miller <davem@davemloft.net>, akpm@osdl.org,
       linux-kernel@vger.kernel.org, openib-general@openib.org,
       tom@opengridcomputing.com
Subject: Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro
References: <adazmag5bk1.fsf@cisco.com>
	<20061124.220746.57445336.davem@davemloft.net>
	<adaodqv5e5l.fsf@cisco.com>
	<20061125.150500.14841768.davem@davemloft.net>
	<20061126011014.GR3078@ftp.linux.org.uk>
From: Roland Dreier <rdreier@cisco.com>
Date: Sat, 25 Nov 2006 17:17:08 -0800
In-Reply-To: <20061126011014.GR3078@ftp.linux.org.uk> (Al Viro's message of "Sun, 26 Nov 2006 01:10:14 +0000")
Message-ID: <adaslg73t2j.fsf@cisco.com>
User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.19 (linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 560
Lines: 15

 > 	(typeof(x))((x + a - 1) & ~(a - 1ULL))

Yes I was being stupid thinking I needed a temporary variable to use
typeof.  But what does the cast to typeof(x) accomplish if we write
things the way you suggested above?  It seems that the right things is
really just

	(((x) + (a) - 1) & ~((typeof(x)) (a) - 1))

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/