Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Richard Zhu <hongxing.zhu@nxp.com>
To:     Ahmad Fatoum <a.fatoum@pengutronix.de>,
        "tharvey@gateworks.com" <tharvey@gateworks.com>,
        Lucas Stach <l.stach@pengutronix.de>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Rob Herring <robh+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        =?iso-8859-2?Q?Krzysztof_Wilczy=F1ski?= <kw@linux.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: RE: [PATCH 0/6] Add IMX8M Mini PCI support
Thread-Topic: [PATCH 0/6] Add IMX8M Mini PCI support
Thread-Index: AQHXhIed1aByXd/Pa0GD1Q7Hp2a0Y6tauTPA
Date:   Fri, 30 Jul 2021 01:27:57 +0000
Message-ID: <VI1PR04MB58533AF76EA4DFD8AD6CDA158CEC9@VI1PR04MB5853.eurprd04.prod.outlook.com>
References: <20210723204958.7186-1-tharvey@gateworks.com>
 <36070609-9f1f-00c8-ccf5-8ed7877b29da@pengutronix.de>
In-Reply-To: <36070609-9f1f-00c8-ccf5-8ed7877b29da@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-2?Q?nfso2gC1J9tCKr5YVa3ooFZYrP6uDbtQ2t8wWASYYdkL+XrEO/T5UCx9Hz?=
 =?iso-8859-2?Q?IYgJ04SjQGuAko1D52F7KaHfv90sOx/6Ks23WA1E1DOdSzFtCK1Qjd8VQY?=
 =?iso-8859-2?Q?Q/i3dqnfj0NvL5p5vXAkdMxzengUztYO5kD02ccm6Y73KxkYbki8J4r86V?=
 =?iso-8859-2?Q?S3RYkIckAg89jf3vxLnK7BHNKlE1OLQt2wcWv15OJe1wOnDm7VFKTuy2lp?=
 =?iso-8859-2?Q?5+PLUtbrWwf377NEqM8eqA0kKgQWbuYG/9pVxEeVTprTukGUYz8tos7BGi?=
 =?iso-8859-2?Q?yY8v2PwHvJsnhHkkXt7k6ZswO4zr2WKGnF7cZ8GoBatHjxHgEGwnLrNrtg?=
 =?iso-8859-2?Q?GgArTRhgx3C2embPdByiLeA40MHRPfzt4iLoC3eGr5gvIVRMeeO1H+RI7c?=
 =?iso-8859-2?Q?Ss847z+74jWnNkiOdXTjp+uyoHvOOBokwR9xk8RSqQbkUzok6eqJO1TBfO?=
 =?iso-8859-2?Q?UTFD9LwdYSzi2l0pkjrJ/1jKfWEkVc/1fFdnI38D9ApkPky3kQl8KHfTJ1?=
 =?iso-8859-2?Q?TOcDwK82iSTUR9SGkYHeZUWuRP9ajJ5C0uH+bmWmjU8yqAixdjkCBmt265?=
 =?iso-8859-2?Q?5VDzjRLHXKURaJIX0FFi9Pno20kSNrSXBNw/Mx0pEUnJHUo5Az9pegez/z?=
 =?iso-8859-2?Q?3MGrnPdUBUdCcn9QfBEtgR0lRYT+9c7Yn2H1zotIL2WvZyGTxTvtRlksyk?=
 =?iso-8859-2?Q?qwS5yshUvsbwccrcRBpgSgkwzgQsYBxvLLYTR4Sxr63wellvx57VMfly99?=
 =?iso-8859-2?Q?vdf0Jsv74tPZj7cIJBsUJEtp4pHhcdjthNgClwFbtppFLF9J0EL7N+ptpv?=
 =?iso-8859-2?Q?LjcayYm6ZFNKpigVKLi2V7eHpRJSIij42tvjLDk0YvYN2i7AlcMH/0vElA?=
 =?iso-8859-2?Q?P63N1CWwsrvyHDwgLWQwNUg2ByQdB6KrpteLUT+it0I4Gn8Z4wdmH3cnW2?=
 =?iso-8859-2?Q?1E0hyvD8OaDEXcb/ei3P+nRH3DKgfB4wTCOWNkwQ1XpmBftxn53OgigW3Z?=
 =?iso-8859-2?Q?CVMFvRctRhdL+WMkdqgHs17ztg1URdVCTkuNQS/LJGrQmH7VGpmepdL3sZ?=
 =?iso-8859-2?Q?JnsxSwsCwHs2aTWjmjA3gwpCFT5Ujtyap8tlCEXgGgEjpwZ31oxaMznSXZ?=
 =?iso-8859-2?Q?6Nn9GOILrIwNK3q5uA5Y41TZb7iNpzyNTMNcwUjuw7dLXUixH1PXJrOfbO?=
 =?iso-8859-2?Q?bkmyvYknhv7ZcbC5s98W4NLyeAy33OR8znDnT8hVW12l4Pdy+ILQqoVvS+?=
 =?iso-8859-2?Q?OSiP6hq7OtAeRtnfE+vSSHkkBrm7t6MC0mfroohWFMHKEvLiphLX9Ra+Zd?=
 =?iso-8859-2?Q?kf7qKAdq6S7yYbpkmGW9B8umK7yU2OESTFpPSeSWHxKHSvH8Ct4SDiAvMW?=
 =?iso-8859-2?Q?vjRaZaBjxh?=
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5853.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3d0fbae-368b-4aae-f0ab-08d952f942e0
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2021 01:27:57.0788
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vn9pAu+9T2mkjx9eUCxVEnuO7boxj5TZNqbcCv+7Qypxg0g4b6QmETpwY0bH5e4KQU3+yn5mxn/B16iu+cDtPA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4221
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Tim:
Just as Ahmad mentioned, Lucas had issue one patch-set to support i.MX8MM P=
CIe.
Some comments in the review cycle.
- One separate PHY driver should be used for i.MX8MM PCIe driver.
- Schema file should be used I think, otherwise the .txt file in the dt-bin=
ding.

I'm preparing one patch-set, but it's relied on the yaml file exchanges and=
 power-domain changes(block control and so on).
Up to now, I only walking on the first step, trying to exchange the dt-bind=
ing files to schema yaml file.

Best Regards
Richard Zhu

> -----Original Message-----
> From: Ahmad Fatoum <a.fatoum@pengutronix.de>
> Sent: Thursday, July 29, 2021 10:40 PM
> To: tharvey@gateworks.com; Richard Zhu <hongxing.zhu@nxp.com>; Lucas
> Stach <l.stach@pengutronix.de>; Bjorn Helgaas <bhelgaas@google.com>;
> Rob Herring <robh+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>;
> Sascha Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>;
> dl-linux-imx <linux-imx@nxp.com>; linux-pci@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; Krzysztof Wilczy=F1ski <kw@linux.com>; Lore=
nzo
> Pieralisi <lorenzo.pieralisi@arm.com>
> Subject: Re: [PATCH 0/6] Add IMX8M Mini PCI support
>=20
> Hello Tim,
>=20
> On 23.07.21 22:49, Tim Harvey wrote:
> > The IMX8M Mini PCI controller shares much in common with the existing
> > SoC's supported by the pci-imx6 driver.
> >
> > This series adds support for it. Driver changes came from the NXP
> > downstream vendor kernel [1]
> >
> > This series depends on Lucas Stach's i.MX8MM GPC improvements and
> > BLK_CTRL driver and is based on top of his v2 submission [2]
>=20
> Are you aware of Lucas' patch series and Rob's remarks there?
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flore.=
ke
> rnel.org%2Flinux-pci%2F20210510141509.929120-7-l.stach%40pengutronix.
> de%2F&amp;data=3D04%7C01%7Chongxing.zhu%40nxp.com%7C21a3e2ba936
> c443581ea08d9529ebf65%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7
> C0%7C637631664036013517%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4
> wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&a
> mp;sdata=3Dblnp2JkmGAZ2w5JHZHJQoZJSuY1646KAT8cccaI5n%2Fw%3D&amp;
> reserved=3D0
>=20
> Cheers,
> Ahmad
>=20
> >
> > The final patch adds PCIe support to the Tim [1]
> > https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fsou=
r
> >
> ce.codeaurora.org%2Fexternal%2Fimx%2Flinux-imx%2F&amp;data=3D04%7C0
> 1%7Ch
> >
> ongxing.zhu%40nxp.com%7C21a3e2ba936c443581ea08d9529ebf65%7C686e
> a1d3bc2
> >
> b4c6fa92cd99c5c301635%7C0%7C0%7C637631664036013517%7CUnknown
> %7CTWFpbGZ
> >
> sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6M
> n0%3
> >
> D%7C1000&amp;sdata=3D5IiG4fnzWkcsV2JPnQJ8gAgMhZSuZypTOixD4lV%2BTf
> g%3D&am
> > p;reserved=3D0
> > [2]
> > https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fpat=
c
> >
> hwork.kernel.org%2Fproject%2Flinux-arm-kernel%2Flist%2F%3Fseries%3D51
> 9
> >
> 251&amp;data=3D04%7C01%7Chongxing.zhu%40nxp.com%7C21a3e2ba936c44
> 3581ea08
> >
> d9529ebf65%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63763
> 166403601
> >
> 3517%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2lu
> MzIiLCJBT
> >
> iI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3DM6%2FzPsxRPv%2Fv7a
> ad7uqjDQY
> > 8LhHOX%2B%2FLzxnuW1UrVgE%3D&amp;reserved=3D0
> >
> > Tim Harvey (6):
> >   dt-bindings: imx6q-pcie: add compatible for IMX8MM support
> >   dt-bindings: reset: imx8mq: add pcie reset
> >   PCI: imx6: add IMX8MM support
> >   reset: imx7: add resets for PCIe
> >   arm64: dts: imx8mm: add PCIe support
> >   arm64: dts: imx8mm: add gpc iomux compatible
> >
> >  .../bindings/pci/fsl,imx6q-pcie.txt           |   4 +-
> >  arch/arm64/boot/dts/freescale/imx8mm.dtsi     |  38 ++++++-
> >  drivers/pci/controller/dwc/pci-imx6.c         | 103
> +++++++++++++++++-
> >  drivers/reset/reset-imx7.c                    |   3 +
> >  include/dt-bindings/reset/imx8mq-reset.h      |   3 +-
> >  5 files changed, 147 insertions(+), 4 deletions(-)
> >
>=20
>=20
> --
> Pengutronix e.K.                           |
> |
> Steuerwalder Str. 21                       |
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fwww.p
> engutronix.de%2F&amp;data=3D04%7C01%7Chongxing.zhu%40nxp.com%7C21
> a3e2ba936c443581ea08d9529ebf65%7C686ea1d3bc2b4c6fa92cd99c5c3016
> 35%7C0%7C0%7C637631664036013517%7CUnknown%7CTWFpbGZsb3d8ey
> JWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D
> %7C1000&amp;sdata=3DjynjjRJZyvooJFXwvz45OU9YB0xr5wA2y%2FkoweEtUq
> U%3D&amp;reserved=3D0  |
> 31137 Hildesheim, Germany                  | Phone:
> +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:
> +49-5121-206917-5555 |