Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp6595254pxv; Thu, 29 Jul 2021 19:45:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhQ+4imgfY6V6gZq/t/Xxd8mtsItJfDe0FAJ5Nzakk3t5wVHaPN3XgQF4uO/3DqNxJV8A1 X-Received: by 2002:a17:906:2bd3:: with SMTP id n19mr456999ejg.232.1627613103423; Thu, 29 Jul 2021 19:45:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627613103; cv=none; d=google.com; s=arc-20160816; b=ff3njWGXpCwEPCosIB565htld0ZsfQfNTRyM6JFAMQAK8rY6V6OkFyY93cp8ZUAq6X qT6wII8rb9jBqIAU+sD6HiQwIl/pTOgv59u5bAwap7dEjNARJKOmxGKXWZBu/oXn3gln 1HT64Rl/j7w+qyF9Qhi25PO1q/HRpH0yCaAwPsPS/6GUWBaayxY6ImylYEvJoBD+IMRY 6CjbjyxyDssSXN0mfsdnv3NcZG/S3eZACLtoLLGvQ/5NNtngTFj9uX0W5QMK637NbZHl 5ydr7o/ds5aT4kC2DUbciG3C1zcajWELHalf3A3GR/PNNz/2YyZIdNknIkyY3tVTCd2P k3fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=2k7fEyFu7zGXyqWbkTSjvJ6JOYMr8rw/z8q7mEIUc8A=; b=aQVw+IULQioRR4eZaBKoxQH2A2WEGmh6LXDNjyBs7Y+N+xwr+iH8krEPG/pO1Io5tL 9c8QirtijJUQJUnWI4dYah+/bW0eag4py/gcRg0uE8YQFTEXk8yFkUUe+eDPV8NrEllr s9s2YoKqP/DPE0dvD5HWeJIizWrF7wEv8ADtpZ4sqiMp4wLIP0Z5PBGziycOE9pMlaP1 FHFsUHTaCF7rQjZzOxO5Pbx2VBPGO4hq6MGF2w1nkaKwcczNaCLTZK2t/3rDX99s053g 5xPSkrlaOSujqFxAvMsCdPze2CM/ghBH7idArqgIVMzygjmAqXVkFNes3ohaOiUHb0b3 TOCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=JgClgnU9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z1si289695edd.187.2021.07.29.19.44.40; Thu, 29 Jul 2021 19:45:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=JgClgnU9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236048AbhG3CnP (ORCPT + 99 others); Thu, 29 Jul 2021 22:43:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230200AbhG3CnP (ORCPT ); Thu, 29 Jul 2021 22:43:15 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 599D3C0613C1 for ; Thu, 29 Jul 2021 19:43:10 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id a20so9363776plm.0 for ; Thu, 29 Jul 2021 19:43:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2k7fEyFu7zGXyqWbkTSjvJ6JOYMr8rw/z8q7mEIUc8A=; b=JgClgnU9EdwSANU8A5FerpxJDoCmKESOX5v+FZM6r2TrDY8Hsmgx4fSSGUaIChBFJW nJ4E/ZBbz1I3MA/8EDBPDxWMF5E3u1sHgvJuQ0NooOw3kwGeUDjcHTC+SoVHq9wRE0PY V4+8QyMzbmoBDl3xFidcOKambkn17SDAQFg8woP+NP1uNpxlfm+hNQguFbWO9M9rTIVj MwfqoK+BfnglDvvyR3no3rQ73c+0mKGVgwByOa85doAmoI1ui4CnZ0yfBRS+cazSq3l2 5gkMKx8CC8QVd/AoL8jHejUm2ApZHIr/tSINLrhVkby6HYZ5KngrD4z7/lZ6WSX0Me4t aXPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2k7fEyFu7zGXyqWbkTSjvJ6JOYMr8rw/z8q7mEIUc8A=; b=uhLiIwRUeY+mloLaJ2VUKEyzQj23FPntwrdHLx982zTpU6CsmIbiWbwP7rtRFusLdD DpuNjvvteLeQcVSL6IOZcNe8tlNQZFYiHEbYPpzh4Nvc7GNoaOFmCjX5fZozrr6jIbmR PlEpEHmOh/9MpEC/JMZNdXrS5WKFuyUM+QHD1qwvYM7dc0AHk0m4tHnPjbJNh3xRIu9u xR1qHayn1NKIohAqQ71vrb3VA1g280WjNOZ/WqkphY4FnATNXOF/a+xdN/lp7Kn2m/h2 IMNYTbuKOFWuCdpMxEfzfXXCMck3Zv4M7rxUN7oz2Qn4yMNe47RnPdPKqmWjATHLK2Tq DanQ== X-Gm-Message-State: AOAM532qdyL539N9ySHEaUAud9/S5QHOBF8pP4XYKG4Pi5b6pEXExsif hyBecvWAZa1XAFckd/B7bIpj2rnRKyVLHN1p5cztTw== X-Received: by 2002:a17:902:6ac9:b029:12c:3bac:8d78 with SMTP id i9-20020a1709026ac9b029012c3bac8d78mr348102plt.34.1627612989962; Thu, 29 Jul 2021 19:43:09 -0700 (PDT) MIME-Version: 1.0 References: <20210729125755.16871-1-linmiaohe@huawei.com> <20210729125755.16871-3-linmiaohe@huawei.com> In-Reply-To: <20210729125755.16871-3-linmiaohe@huawei.com> From: Muchun Song Date: Fri, 30 Jul 2021 10:42:29 +0800 Message-ID: Subject: Re: [PATCH 2/5] mm, memcg: narrow the scope of percpu_charge_mutex To: Miaohe Lin Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Matthew Wilcox , Alex Shi , Wei Yang , Linux Memory Management List , LKML , Cgroups Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 29, 2021 at 8:58 PM Miaohe Lin wrote: > > Since percpu_charge_mutex is only used inside drain_all_stock(), we can > narrow the scope of percpu_charge_mutex by moving it here. > > Signed-off-by: Miaohe Lin LGTM. Reviewed-by: Muchun Song