Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210706114120.197-1-alistair@alistair23.me> <CAKmqyKP8HKERLS3ckOA3wwpiv6J4tdFXn8-d6wXxDXDGn5iN=w@mail.gmail.com>
 <20210729112246.GL4670@sirena.org.uk>
In-Reply-To: <20210729112246.GL4670@sirena.org.uk>
From:   Alistair Francis <alistair23@gmail.com>
Date:   Fri, 30 Jul 2021 16:11:51 +1000
Message-ID: <CAKmqyKNyvE7wL-sRW7h7LoZJvwpDwMZFvXSLBB9ziz+01fPu1w@mail.gmail.com>
Subject: Re: [PATCH 1/2] regulator: sy7636a: Remove the poll_enable_time
To:     Mark Brown <broonie@kernel.org>
Cc:     Alistair Francis <alistair@alistair23.me>, lgirdwood@gmail.com,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jul 29, 2021 at 9:22 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Thu, Jul 29, 2021 at 09:20:14PM +1000, Alistair Francis wrote:
> > On Tue, Jul 6, 2021 at 9:41 PM Alistair Francis <alistair@alistair23.me> wrote:
> > >
> > > From testing on hardware the poll_enable_time isn't required and
> > > sometimes causes the driver probe to fail so let's remove it.
> > >
> > > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> >
> > Ping
>
> Please don't send content free pings and please allow a reasonable time
> for review.  People get busy, go on holiday, attend conferences and so
> on so unless there is some reason for urgency (like critical bug fixes)
> please allow at least a couple of weeks for review.  If there have been
> review comments then people may be waiting for those to be addressed.

Sorry, I was following what happens with some other projects and
pinging after a few weeks.

>
> Sending content free pings adds to the mail volume (if they are seen at
> all) which is often the problem and since they can't be reviewed
> directly if something has gone wrong you'll have to resend the patches
> anyway, so sending again is generally a better approach though there are
> some other maintainers who like them - if in doubt look at how patches
> for the subsystem are normally handled.

Ok, in future I'll try to follow what others in the subsystem do.

Alistair