Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp6732055pxv; Fri, 30 Jul 2021 00:34:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwE8SpG0CI86MOTcyfg/zykTVkfQwJ7YJiT3lRYvPyqr9nDAXjDZJkeSJhPF1A95/eu1ySq X-Received: by 2002:a17:906:b104:: with SMTP id u4mr1228212ejy.201.1627630479736; Fri, 30 Jul 2021 00:34:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627630479; cv=none; d=google.com; s=arc-20160816; b=N5HA+rxW+wjK5Zw4FhY3KgCMzxVFe98i4e/bgUBTvktjHxwQXJOnVdhFDekCh+YGS2 LTxtDmfu2aw3QKbyVbXmDIfwyTntfL4a2w3xLJuOz1mqQC3F7BNM9U3QkEqm3AYQnrUc 6sShTy48LBQzNBfbFBihvU0/EZeLB9vHpsUVnIAylEn4v+nV04SGKQYW4vl7w0zlwwbw DsyPQJWwu1ba2SKiBbw5EHF39l6wuKOXLP4IQTUb9NdnJ9l5FmlIXbuglIVh09P74Swf in0GAwwYz5Cu+GpGIQMYfLjIKONvuhzYu9R1OVBkh0KREew8sbMkXOgwJQP0d+/JKaK8 43QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7heehBNik1PqStWJbc/QwvZU+LEALLlO102LtLzNzN8=; b=BKR2hFQsFTm7I5Wvtz6AUS2yoYlCPAA+aJsSyJd/9bCDP2b7cymQG04xT+eRp2GR1m YUkdamQQNeYB6gLuGuWo/uo9KAClV9xcLdjTbNBfkKo8yt6mHLj3Iug29hGcZMcQwjjp L3DRp678GwlyooSvDuxGllmFPF9/5pAzHRPW7kwa6egrca/tKKuf9DxaH7dNlbcA7pFH RxU33nx6CKxwx9xa+AnUXHo8r4TNOkhbrcL0cS3fo/SZWwOKNtGxUslsYAn1IOwAwqiQ iTW+SpeK4G4EcyJ9a4agEqYMG40/1jie0QbPzIFSHQ9o3rLq85dv6ZLOI1QZcEjDMcpQ cHRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=dO1+GXtZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j11si835055ejj.109.2021.07.30.00.34.15; Fri, 30 Jul 2021 00:34:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=dO1+GXtZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230337AbhG3Hcp (ORCPT + 99 others); Fri, 30 Jul 2021 03:32:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237472AbhG3Hcp (ORCPT ); Fri, 30 Jul 2021 03:32:45 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AD0FC061765 for ; Fri, 30 Jul 2021 00:32:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7heehBNik1PqStWJbc/QwvZU+LEALLlO102LtLzNzN8=; b=dO1+GXtZ30eoeb8GdhAZmNVgn+ IrjTJ0+XksbmvQduzJtVvJHyc+rtZKy4t/z+EYk0BgQcaZxqMwo7nYEQJquASN7+QK0t7oE2q5ZIA u4dQJdKbcnkQgQlbx9/Qq1KNoOVB1BH1Uj2sSxw7NZhK9Um6Gp2/QDQmCYpfWDtYcw0U50isE4Sua mR5MD86ss4I+dSwFGhx9cKWLKJi2pb/hquZf4cjdB4+k2LCYAQhIzRELpUixx3ftut3Nq+RZ50bAE 50AzY7R44FKIIK9fUcB+vc3+OKi4nZGeaYi+tcMk3YtTrSn7meJenTGiPsuhonTkynmHz3+rCiBZZ yq8sakSQ==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9MzC-000Scy-Hl; Fri, 30 Jul 2021 07:31:37 +0000 Date: Fri, 30 Jul 2021 08:31:14 +0100 From: Christoph Hellwig To: John Hubbard Cc: Andrew Morton , LKML , linux-mm@kvack.org, Mel Gorman , Rik van Riel , Christoph Hellwig , "David S . Miller" , Eric B Munson , Eric Paris , James Morris , Mike Christie , Neil Brown , Peter Zijlstra , Sebastian Andrzej Siewior , Trond Myklebust , Xiaotian Feng , Mark Salter Subject: Re: [PATCH] mm: delete unused get_kernel_page() Message-ID: References: <20210729221847.1165665-1-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210729221847.1165665-1-jhubbard@nvidia.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 29, 2021 at 03:18:47PM -0700, John Hubbard wrote: > get_kernel_page() was added in 2012 by [1]. It was used for a while for > NFS, but then in 2014, a refactoring [2] removed all callers, and it has > apparently not been used since. Looks good, pinnining by kernel virtual address doesn't really make much sense. Reviewed-by: Christoph Hellwig