Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp6733695pxv; Fri, 30 Jul 2021 00:37:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx84EgNWlkV8k/Hm/Jy9MBOecMtkm92HM91VFnVaXIciVJu4AnqI2/DbZ2+I0otfeRdqXQR X-Received: by 2002:a6b:fe19:: with SMTP id x25mr55867ioh.39.1627630667303; Fri, 30 Jul 2021 00:37:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627630667; cv=none; d=google.com; s=arc-20160816; b=spvdpN60NE7XVb/Nl29Qdo+DixZnosgK2zRdTRKdX5/gfSM0MkGNYiKpBD1cuh+Abz vAEUwHsdTRuR5v8E4CpaewZRF43ncZG3vGPU7oGZ8CBh21Jtot3FDT0MQSbdfTG5XZZv QVXqqkCDsRXiFFwQN3UfjzPZYRnelAAJe9/9fzaOc7cGByzkYcdycsPCnv25WVCZ/G0R gJ9kcP6w/RxXscCKE/7qLuRMZLyV959zyCEt6Td2iqxCQjzLl2O1lb5uXZYvy8c10HFs p3PhRc53UnSg5wr25HoMt0zkcWC7cPWz4zVUKRlkaP4yDdEHg69JmB9Vu4ND5gKb/2G7 NkBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:message-id:in-reply-to :subject:cc:to:from:date:dkim-signature; bh=7byT5bHnPOS7y5EU7qUuO5PL/0UgHrhgbJIWzprjQ1c=; b=YQhnhdps0n94ESLXIQySMw0kWOyJmiYOHFSLo7t2Adv16TA82XtCGOpKHa2saaU/Ef GevqbOevsGsyHZzAc9xEm1JY3T0wuVkJu9NMvV6q3vnu/AZ/l5FL1cIw+ud2Gz7Wjnm9 /tZoHjBLqVDZB6nBJ4LPCondVMBOT1VuaYoatarsOxwSJMl/rtFRpLK8RQ3RCpE1KMas KH26xORwaGlie03eZu24Q+1XeyL7ShA9BwV4mpwKJW2EKswJD0sgdGu7dIopIaSzrCDF Atf5+xgU6UNNLzIodKHrbgYMUWYXOKRt5mHBl/eqrWR+kR4+dmgDrB2NUwPwYL/JzjmT tyFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=ORF4v5oD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z9si1078733jat.41.2021.07.30.00.37.34; Fri, 30 Jul 2021 00:37:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=ORF4v5oD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237616AbhG3Hg6 (ORCPT + 99 others); Fri, 30 Jul 2021 03:36:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230337AbhG3Hg6 (ORCPT ); Fri, 30 Jul 2021 03:36:58 -0400 Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4583C0613CF for ; Fri, 30 Jul 2021 00:36:53 -0700 (PDT) Received: by mail-ot1-x333.google.com with SMTP id f20-20020a9d6c140000b02904bb9756274cso8596398otq.6 for ; Fri, 30 Jul 2021 00:36:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=7byT5bHnPOS7y5EU7qUuO5PL/0UgHrhgbJIWzprjQ1c=; b=ORF4v5oDyw8K3+2KbHlXODBIhFHkD4R+F5BXpH8NINHorwAPc7YVmxWyBoy0+VRNAE iRWPTSbOiINERDx6exN7IO5B2+rcQcvZKXTcCtE6QuIObLXuRcETqSxKpDTl4aDVED1W flpybY/IOPY94ZThriNdKbiu4eo4W1HVyfAMe/K+b+McrV4pVrGqz4sHsXLKuhULr0Sy 40L+6BulBdvLKtEDZvIKsPD999DXg6gVvLsh71e+BnYj3vnSg9H1aPldHjOBlpO9edCs /j8px2PnkGQnzt0Y30GWdAI+gXcB/8smhs7YN+/5xTUpp4FKs2IW42nOcpRARJEEu3wt sGlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=7byT5bHnPOS7y5EU7qUuO5PL/0UgHrhgbJIWzprjQ1c=; b=U3wk28FbXpSmDZl4gQrclAd9qrrNtyh4g1R8wt5Dh7nImrMQocSNYLZnhtKYl7i1ma dPtn5j+u7256CR8y51wM8asqkOgjB3WCOubvVMp2Ds7H8gLiyYu62kkWTjsFxDx8q7wV QjSN/wPNjnwFuEtYHFdITchmINASzTIzS0kwBbCdYtrO1+cvUIUVq0JUjCpO23L+vM1e N2lOWP32+vj7aD2DEdpmQ0ijtkqKi9VjLW93iUVFsR2jeyofvHuX6xuomTk0U9dr05hv phDi9pcRq/G4Dp3DpYQuQrAJXOWQKRGrkQMcwQ7bmcLFu3BCysZihYcdEOjW24JnNrRZ VGTg== X-Gm-Message-State: AOAM5314iq0iMxCmFZZmhT3/emrIyCvJpq5jEedc2Urt4Bz2wcJ+7Y/p u2fnywDasoAFqxCP4pTkHigz4Q== X-Received: by 2002:a9d:4911:: with SMTP id e17mr1093386otf.38.1627630613080; Fri, 30 Jul 2021 00:36:53 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id b70sm172434oii.24.2021.07.30.00.36.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jul 2021 00:36:52 -0700 (PDT) Date: Fri, 30 Jul 2021 00:36:48 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.anvils To: Andrew Morton cc: Hugh Dickins , Shakeel Butt , "Kirill A. Shutemov" , Yang Shi , Miaohe Lin , Mike Kravetz , Michal Hocko , Rik van Riel , Christoph Hellwig , Matthew Wilcox , "Eric W. Biederman" , Alexey Gladkov , Chris Wilson , Matthew Auld , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 04/16] huge tmpfs: revert shmem's use of transhuge_vma_enabled() In-Reply-To: <2862852d-badd-7486-3a8e-c5ea9666d6fb@google.com> Message-ID: References: <2862852d-badd-7486-3a8e-c5ea9666d6fb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 5.14 commit e6be37b2e7bd ("mm/huge_memory.c: add missing read-only THP checking in transparent_hugepage_enabled()") added transhuge_vma_enabled() as a wrapper for two very different checks: shmem_huge_enabled() prefers to show those two checks explicitly, as before. Signed-off-by: Hugh Dickins --- mm/shmem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/shmem.c b/mm/shmem.c index ce3ccaac54d6..c6fa6f4f2db8 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -4003,7 +4003,8 @@ bool shmem_huge_enabled(struct vm_area_struct *vma) loff_t i_size; pgoff_t off; - if (!transhuge_vma_enabled(vma, vma->vm_flags)) + if ((vma->vm_flags & VM_NOHUGEPAGE) || + test_bit(MMF_DISABLE_THP, &vma->vm_mm->flags)) return false; if (shmem_huge == SHMEM_HUGE_FORCE) return true; -- 2.26.2