Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp6772519pxv; Fri, 30 Jul 2021 01:53:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQt5shcBBmXtV2fd01xbDPHxoqUHcl4bJMfzZiSJsa6aN9YlgHq/9TnnyU1S6d344F1a4h X-Received: by 2002:a92:c5c2:: with SMTP id s2mr342981ilt.180.1627635184185; Fri, 30 Jul 2021 01:53:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627635184; cv=none; d=google.com; s=arc-20160816; b=uUXSsn/jOh429soDhMg30Rxegr4gpfJRLMxFcxEVni23ILQgH2T5HpYb6WuyyrQqJu W0D61y2Uf8PmgPBkICdl9s8wqVXGLZEsterowLjRSQlPqcMtUR+DqYdhpYRyHtWJJibC Erbz1VsbmwQ/ZpSDTf6o5LMzxJuewQNJzWvT+HfwW3QaY8eGIhqgUJ4u9NA8XEiAQqwl fuHOTlJIsNBUQvwFjgV8VwSYena7nO9tfJFpY40US++Sj00gToWDSM+5JOoFvXj1EYal Qyh1oujFDxJjoXDjsnmxyNVzKzmgM/Co8rnp4A3hcK7EViAmvH8ZeuYJeazBYPIZGdc0 LwzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=AE/qyRydek0h3EBza2eyJHziGTQSqtMnAASgc9rHNLQ=; b=qZ8WA2oIz4dBxbSlB7Ql562QfWovUNoFCPw3R2sMt1BLr9jzk9Y9j9eyEzoye7uA1R Y5rbcx1R8en6aRAJAmMQo5i1zAYr6+aISBvecrf5E5cj66v+goKMSv6/39WK2iZqzsNc +U/36Jc01G9V+emddeT6nEUz6+lCDbMJvP/Dk8QPcenOlMnxf/ioWdoyk+FEHaUQ0Ios UgJ6CGWDaiFDkJmQBWsfz3knO5V4Wh1/DbGHAGWyfDwb1GLdm8m0nbwCpGfEaKKDvhpC LY3oqF6S3UYpcFiLrDzYX5lRb+diFWsmbRUrNW0WFHBN7gQdG6XfYmCgRc5tJ32cgJBF Q5tQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w12si1216495ilv.127.2021.07.30.01.52.51; Fri, 30 Jul 2021 01:53:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238083AbhG3IvD (ORCPT + 99 others); Fri, 30 Jul 2021 04:51:03 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:35988 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S238107AbhG3Ius (ORCPT ); Fri, 30 Jul 2021 04:50:48 -0400 X-UUID: 49a1c0051d9b4b04aa32b9386a627afc-20210730 X-UUID: 49a1c0051d9b4b04aa32b9386a627afc-20210730 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1148182922; Fri, 30 Jul 2021 16:50:39 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs06n2.mediatek.inc (172.21.101.130) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 30 Jul 2021 16:50:38 +0800 Received: from localhost.localdomain (10.17.3.153) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 30 Jul 2021 16:50:37 +0800 From: Chunfeng Yun To: Rob Herring , Mathias Nyman CC: Chunfeng Yun , Greg Kroah-Hartman , Matthias Brugger , , , , , , Eddie Hung Subject: [PATCH 04/11] usb: xhci-mtk: fix use-after-free of mtk->hcd Date: Fri, 30 Jul 2021 16:49:55 +0800 Message-ID: <1627635002-24521-4-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 1.8.1.1.dirty In-Reply-To: <1627635002-24521-1-git-send-email-chunfeng.yun@mediatek.com> References: <1627635002-24521-1-git-send-email-chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org BUG: KASAN: use-after-free in usb_hcd_is_primary_hcd+0x38/0x60 Call trace: dump_backtrace+0x0/0x3dc show_stack+0x20/0x2c dump_stack+0x15c/0x1d4 print_address_description+0x7c/0x510 kasan_report+0x164/0x1ac __asan_report_load8_noabort+0x44/0x50 usb_hcd_is_primary_hcd+0x38/0x60 xhci_mtk_runtime_suspend+0x68/0x148 pm_generic_runtime_suspend+0x90/0xac __rpm_callback+0xb8/0x1f4 rpm_callback+0x54/0x1d0 rpm_suspend+0x4e0/0xc84 __pm_runtime_suspend+0xc4/0x114 xhci_mtk_probe+0xa58/0xd00 This may happen when probe fails, needn't suspend it synchronously, fix it by using pm_runtime_put_noidle(). Reported-by: Pi Hsun Signed-off-by: Chunfeng Yun --- drivers/usb/host/xhci-mtk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c index 2548976bcf05..cb27569186a0 100644 --- a/drivers/usb/host/xhci-mtk.c +++ b/drivers/usb/host/xhci-mtk.c @@ -569,7 +569,7 @@ static int xhci_mtk_probe(struct platform_device *pdev) xhci_mtk_ldos_disable(mtk); disable_pm: - pm_runtime_put_sync_autosuspend(dev); + pm_runtime_put_noidle(dev); pm_runtime_disable(dev); return ret; } -- 2.18.0