Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] mm: delete unused get_kernel_page()
To:     John Hubbard <jhubbard@nvidia.com>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     LKML <linux-kernel@vger.kernel.org>, linux-mm@kvack.org,
        Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
        Christoph Hellwig <hch@infradead.org>,
        "David S . Miller" <davem@davemloft.net>,
        Eric B Munson <emunson@mgebm.net>,
        Eric Paris <eparis@redhat.com>,
        James Morris <jmorris@namei.org>,
        Mike Christie <michaelc@cs.wisc.edu>,
        Neil Brown <neilb@suse.de>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Sebastian Andrzej Siewior <sebastian@breakpoint.cc>,
        Trond Myklebust <Trond.Myklebust@netapp.com>,
        Xiaotian Feng <dfeng@redhat.com>,
        Mark Salter <msalter@redhat.com>
References: <20210729221847.1165665-1-jhubbard@nvidia.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
Message-ID: <3551cde6-b48f-8cfc-7b64-b3341e717716@redhat.com>
Date:   Fri, 30 Jul 2021 11:17:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210729221847.1165665-1-jhubbard@nvidia.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 30.07.21 00:18, John Hubbard wrote:
> get_kernel_page() was added in 2012 by [1]. It was used for a while for
> NFS, but then in 2014, a refactoring [2] removed all callers, and it has
> apparently not been used since.
> 
> Remove get_kernel_page() because it has no callers.
> 
> [1] commit 18022c5d8627 ("mm: add get_kernel_page[s] for pinning of
>      kernel addresses for I/O")
> [2] commit 91f79c43d1b5 ("new helper: iov_iter_get_pages_alloc()")
> 
> Cc: Mel Gorman <mgorman@suse.de>
> Cc: Rik van Riel <riel@redhat.com>
> Cc: Christoph Hellwig <hch@infradead.org>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Eric B Munson <emunson@mgebm.net>
> Cc: Eric Paris <eparis@redhat.com>
> Cc: James Morris <jmorris@namei.org>
> Cc: Mike Christie <michaelc@cs.wisc.edu>
> Cc: Neil Brown <neilb@suse.de>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
> Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
> Cc: Xiaotian Feng <dfeng@redhat.com>
> Cc: Mark Salter <msalter@redhat.com>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
> 
> Hi,
> 
> Just a minor decluttering: I ran across this while looking for something
> else entirely, and then noticed that it's been orphaned for quite a long
> time. It seems like only the plural form of this function is needed
> these days, and probably in the coming days as well.
> 
> thanks,
> John Hubbard
> NVIDIA

Reviewed-by: David Hildenbrand <david@redhat.com>


-- 
Thanks,

David / dhildenb