Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] memory: omap-gpmc: Clear GPMC_CS_CONFIG7 register on
 restore if unused
To:     Tony Lindgren <tony@atomide.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc:     linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
References: <20210727101034.32148-1-tony@atomide.com>
From:   Roger Quadros <rogerq@kernel.org>
Message-ID: <f0a0dfe8-a185-2b14-e12a-ebdd6e2c909f@kernel.org>
Date:   Fri, 30 Jul 2021 13:59:51 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210727101034.32148-1-tony@atomide.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 27/07/2021 13:10, Tony Lindgren wrote:
> We want to clear any unused GPMC_CS_CONFIG7 register on restore to
> ensure unused chip selects are not enabled.
> 
> Cc: Roger Quadros <rogerq@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>

Acked-by: Roger Quadros <rogerq@kernel.org>

Sorry if you got this twice. I got a bounce back on the previous Ack.

cheers,
-roger

> ---
>  drivers/memory/omap-gpmc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -2595,6 +2595,8 @@ void omap3_gpmc_restore_context(void)
>  				gpmc_context.cs_context[i].config6);
>  			gpmc_cs_write_reg(i, GPMC_CS_CONFIG7,
>  				gpmc_context.cs_context[i].config7);
> +		} else {
> +			gpmc_cs_write_reg(i, GPMC_CS_CONFIG7, 0);
>  		}
>  	}
>  }
>