Received: by 2002:a9a:4c47:0:b029:116:c383:538 with SMTP id u7csp7561655lko;
        Fri, 30 Jul 2021 06:30:09 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzl3Ee9qXbyGqfXunWo/WkuNDx+tYf0vrP/Z/C1ZyXZmkss1ONWF9UayuCnzi8bx+dOt0cW
X-Received: by 2002:a92:de09:: with SMTP id x9mr1077308ilm.284.1627651809675;
        Fri, 30 Jul 2021 06:30:09 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1627651809; cv=none;
        d=google.com; s=arc-20160816;
        b=cBHLRjgZLKD48JA/j8LDMgsTxZrLqks+n2tRDX/zckof5r8eevb3Hwq++S/3Q3gMGb
         ohRfGOq4f2VmONHNj1EvDOcA92M86l5hLAA5Xz/7qCUXJePMgF0BWJQF2m3IZyWQaSzI
         t52DTgCFC/MDUjiTGHfGagpyOpyb8yrOwkUML6FQtIgcDkKpfy6mn6G7JeriuNddy+N/
         0sGdFpHi2siHj7oNOFypXQ8m+vJbvdt+6+hAx7N6Y7uGe1qda83bx3r2JnmQeAFcYrzZ
         9f4aZkgBM+nxBxG3MuNX59Uucf0X+ia7VDa3QoyM2LASY4iVCnpyD2bOeYwbAmNVtdVJ
         Cjbg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=lcYXj9NLIh2yPWMqK7gayWpCbV50OVemIedMNHZPhcU=;
        b=IpqADoor2dwikuphh9Yl3OL1N3OSzdTvwkImWmm+7izTZdPQ/FczKkTO59zZ6/umT1
         COl9itFDcTx1ezeJSYVxIavUbAy2vwYSVZLJ2feaigDEtHljI9+E6XRKz4XTok7qTYZh
         Zf6vm2jtD38G7Y9bwfdVfQeiIpCFGcl3bEfoOzIfJOuz433iklmb3gpXfm045yARSfsC
         ESr/ePfeaVJqpbe9zn1661JjFMtd9iSFV9m8zRmB7zZCzKLaRAo2NzH7juK3FPZLWl0t
         ot1UvwsXkdAfE4cNMq59rCzAX3QO3Jzq32M9UWHb8hCAPVSujijnp40iSHTXxog+h9gm
         4WtQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=I7FnHh7J;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id z4si1890708ioz.87.2021.07.30.06.29.57;
        Fri, 30 Jul 2021 06:30:09 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=I7FnHh7J;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S238962AbhG3N26 (ORCPT <rfc822;linux.sihyeon@gmail.com>
        + 99 others); Fri, 30 Jul 2021 09:28:58 -0400
Received: from mail.kernel.org ([198.145.29.99]:38716 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S238926AbhG3N25 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 30 Jul 2021 09:28:57 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id D58FC60EFF;
        Fri, 30 Jul 2021 13:28:52 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1627651733;
        bh=6cUNpTEpCjdVhmy4dYzGo7E9CQFWo+Eq5w2YWTpenR0=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=I7FnHh7JuJe66PDfWEvRk9kDgIo77CqZLMzHk0DUwhBSu5AmDytrV4GUnzh7/UFfw
         NuvDwWuVpLAnNQk12fHQ5avzlfeFXRZ6WwOP8uuV6ihqeJ4Rt55EhFR8cG6O+lIc4V
         RxWCx6OhHMqFuq+CzW8PN/pOVtwaodeGiFs5SoXHAcbb8d2o8xAHn2lV1vtozD+Yb7
         arh5bpY3AWS9eWw+kKwqI38Vy4IQiMeDtFVg1zldpUbY/2aQ2XQZLVZEsWS/WwP5OB
         TuUxcxWhqcIIuv4VF0eVGGkGcsP8I/aDOAj3Q9RHns9Pv1IHjDdVJ22zDF0auZPpqY
         V+Z2P//QNrFeg==
Date:   Fri, 30 Jul 2021 06:28:52 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Florian Fainelli <f.fainelli@gmail.com>,
        Tang Bin <tangbin@cmss.chinamobile.com>
Cc:     davem@davemloft.net, bcm-kernel-feedback-list@broadcom.com,
        netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bcm63xx_enet: simplify the code in bcm_enet_open()
Message-ID: <20210730062852.3d41cc52@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <d5079143-00e3-75d3-cdb0-037c377c526e@gmail.com>
References: <20210729070627.23776-1-tangbin@cmss.chinamobile.com>
        <d5079143-00e3-75d3-cdb0-037c377c526e@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 29 Jul 2021 14:23:28 -0700 Florian Fainelli wrote:
> On 7/29/21 12:06 AM, Tang Bin wrote:
> > In the function bcm_enet_open(), 'ret = -ENOMEM' can be moved
> > outside the judgement statement, so redundant assignments can
> > be removed to simplify the code.
> > 
> > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>  
> 
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>

I wouldn't, the existing code is more robust IMO, but your call :)

Does not apply to net-next, please rebase.