Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp6979291pxv; Fri, 30 Jul 2021 07:14:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsJdrhWx65E13pz3GdR4khQk7kcLXFrUsdZiFvewweYbJwGuqF0+SCqu2hbjN8Q8XtaWIp X-Received: by 2002:a02:cd0a:: with SMTP id g10mr2346463jaq.18.1627654440422; Fri, 30 Jul 2021 07:14:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627654440; cv=none; d=google.com; s=arc-20160816; b=K6pBWXAHPQUDlj1WcRmubott8tDp+9xU4bz5DIS5/wxtK5ZEA+BhCdUSEkSSGYqpL3 X+ryRb26dt4o4HoArAe9LgvJCfkZ5xTEEdXEExmr+dY36ch4oVAHK6cV95ccWi1BXWDF hUMG+JXL9RhJ9QBSnr8kKy4MnLhsm+3MUrclGt4lsHo8m/b4rmgyqLiDZy7tJ1hUoWOV 8MlVu39zY2oL+F/Bzmxmw3/vfB0g3WJGyiNeeq/Ynps3MDigs4iPETJrTGGqKTkVM4HV PQHzTc6ApV5eqMMNKzAUuiK2U9awLhGk6Kib1USRAh2Dt+LjAl5x2A6JiY3O5rXkdCBI sNEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=PSdxmUDyC7yrezT0RsF+4fYYuOcGYHAN9a473RjQQp8=; b=pfeg2KrN6ReR5hOplN3hUnPoJu1oHI69YhXZ5GkGRQXevlG+6X4YorXsxSrCDhknYX 7DKvS5N7uZTGFoY+RdycgawU8xgNII6Gy+ANS5pHC1aadgD7NjUNILRfZooVOgMKhYEj g/yMwblEaF8vyJCKfMmFE7S+3ZKX9smA8ZkfQNoIMnxLQnaCdODTOdJwuS53+rOI6z/x 1LVoF8Lhl92r4xhncBQwl009NeQLIK5QLXa5XJyVaVzcdaIvG4W4VYaLiuO719XWElvT wc7eWJGPoDWtn+ZEcLcppBMH/dMcGEu/S+kU/TqbgPGikNHlkxTqtV47aJVnftp9KN43 jBMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l7si2113487jad.82.2021.07.30.07.13.48; Fri, 30 Jul 2021 07:14:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239018AbhG3OMu (ORCPT + 99 others); Fri, 30 Jul 2021 10:12:50 -0400 Received: from mga01.intel.com ([192.55.52.88]:9264 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238962AbhG3OMo (ORCPT ); Fri, 30 Jul 2021 10:12:44 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10060"; a="235014994" X-IronPort-AV: E=Sophos;i="5.84,282,1620716400"; d="scan'208";a="235014994" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2021 07:12:39 -0700 X-IronPort-AV: E=Sophos;i="5.84,282,1620716400"; d="scan'208";a="518961685" Received: from spichard-mobl1.amr.corp.intel.com (HELO [10.212.106.239]) ([10.212.106.239]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2021 07:12:39 -0700 Subject: Re: [PATCH v1] ASoC: Intel: kbl_da7219_max98357a: fix drv_name To: Cezary Rojewski , Lukasz Majczak Cc: upstream@semihalf.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20210730115906.144300-1-lma@semihalf.com> <58b46549-9b42-1832-b1e1-680d56c3f393@linux.intel.com> From: Pierre-Louis Bossart Message-ID: <6a0866a7-aec4-69d9-eb70-07931952b732@linux.intel.com> Date: Fri, 30 Jul 2021 09:12:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/30/21 9:05 AM, Cezary Rojewski wrote: > On 2021-07-30 3:55 PM, Pierre-Louis Bossart wrote: >> On 7/30/21 6:59 AM, Lukasz Majczak wrote: > > ... > >>> @@ -113,7 +113,7 @@ struct snd_soc_acpi_mach >>> snd_soc_acpi_intel_kbl_machines[] = { >>>       }, >>>       { >>>           .id = "DLGS7219", >>> -        .drv_name = "kbl_da7219_mx98373", >>> +        .drv_name = "kbl_da7219_max98373", >> >> this one is wrong though? The correct name was already present, you're >> reverting back to the wrong name. >> >> there's another one that I missed, do you mind changing this as well? >> >> soc-acpi-intel-cml-match.c:             .drv_name = >> "cml_da7219_max98357a", >> >> Should be "cml_da7219_mx98357a" >> >> > > Not saying 'nay' or 'yay' but why is configuration first available on > KBL platforms being renamed to 'cml_XXX'? The same bxt_da7219_max98357a.c machine driver is used for multiple devices. static const struct platform_device_id bxt_board_ids[] = { { .name = "bxt_da7219_mx98357a" }, { .name = "glk_da7219_mx98357a" }, { .name = "cml_da7219_mx98357a" }, { } }; MODULE_DEVICE_TABLE(platform, bxt_board_ids); Why there are different drivers for KBL and BXT is probably lost in history.