Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 30 Jul 2021 09:59:36 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Steve Bennett <steveb@workware.net.au>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: micrel: Fix detection of ksz87xx switch
Message-ID: <20210730095936.1420b930@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20210730105120.93743-1-steveb@workware.net.au>
References: <20210730105120.93743-1-steveb@workware.net.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Please extend the CC list to the maintainers, and people who
worked on this driver in the past, especially Marek.

On Fri, 30 Jul 2021 20:51:20 +1000 Steve Bennett wrote:
> The previous logic was wrong such that the ksz87xx
> switch was not identified correctly.

Any more details of what is happening? Which extact device do you see
this problem on?

I presume ksz87xx devices used to work and gotten broken - would you
mind clarifying and adding a Fixes tag to help backporting to the
correct stable branches?

> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index 4d53886f7d51..a4acec02c8cb 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -401,11 +401,11 @@ static int ksz8041_config_aneg(struct phy_device *phydev)
>  }
>  
>  static int ksz8051_ksz8795_match_phy_device(struct phy_device *phydev,
> -					    const u32 ksz_phy_id)
> +					    const u32 ksz_8051)

bool and use true/false in the callers?