Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp7293292pxv; Fri, 30 Jul 2021 15:05:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBv4Fjx/6guupUNBWUYrhdd21byENxwxeSTUDvSGv01E2hynakT0AIYsKDt0NFirt3/84Q X-Received: by 2002:a92:3610:: with SMTP id d16mr3016661ila.16.1627682753811; Fri, 30 Jul 2021 15:05:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627682753; cv=none; d=google.com; s=arc-20160816; b=PfeC0ItYSaHwDOCLxQfVyY4EE3U3paN93no1U6es5+x2jeV9kRhtQzlJtWsIjYuywN FqTye7lbz0Z+TRen3hK82GZ88PIsbihkEvoD+hIvhBDKwtBdQv1VG45WWnTnNI4UjvWh BuI8h2CMaCCPdtOHTHd67ZSAtIpgDlHI1go4Aok/R9X/PHAXRtl55fyy9j+I74TWZy3E V8VIcxLccnj3yLqD5oUh4TJzrZCtiEKdru0TAD0yuzzX4bR615CNTeKvg1W1Eo5jwI3M YXP6c9A5UyjVxA6vhEEUIfinAJ32UHJgonHHMeDsb7C1tj+zIM1vnSFSXNz9GDGx2OKI +8dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=kX+SI0U5aiSMEng9KxDplGYqUoU8e9L5SFOV9F7L7N4=; b=Mn9llPFtRvV6SkFvUJ/+HekKHKBOPuzNwPFKJDfi8R1zME5f+bLjT3232n+wmp0NJK Xj+Wy0k9ox8d01Ofl4YR/ap36rZLbc4BOyziFAj+A7KcrDVrISy9+833pYCGZUZfFL+G ulzogDEiql081m54fGZi/X2dJqh5AbhH0latfNKWQkZor+zWrq4yTeDGMtPpy+cJG+lW lSYiqm4JRVjXRM0I/Gdi8c8xUXowApfKYgDEsTlehpSPqkNu8CPaunZzuwwbaRkyimay nreluHoOjqQ30xrL0Mc9RsF5JaNKqYFs3uWWEesxbugbt+HB6mfl3zEb6lxlpVEJB/9j /fwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d1si3265012ila.26.2021.07.30.15.05.40; Fri, 30 Jul 2021 15:05:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232889AbhG3WEe (ORCPT + 99 others); Fri, 30 Jul 2021 18:04:34 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:40910 "EHLO mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230515AbhG3WEe (ORCPT ); Fri, 30 Jul 2021 18:04:34 -0400 X-Greylist: delayed 431 seconds by postgrey-1.27 at vger.kernel.org; Fri, 30 Jul 2021 18:04:33 EDT Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 77EAD8280F; Fri, 30 Jul 2021 21:57:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo01-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo01-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qb7Laqtfqbm5; Fri, 30 Jul 2021 21:57:17 +0000 (UTC) Received: from mail.gonehiking.org (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) by mailout.easymail.ca (Postfix) with ESMTPA id 26CCF8262C; Fri, 30 Jul 2021 21:57:17 +0000 (UTC) Received: from [192.168.1.4] (internal [192.168.1.4]) by mail.gonehiking.org (Postfix) with ESMTP id 6AF7A3EE3E; Fri, 30 Jul 2021 15:57:16 -0600 (MDT) Subject: Re: [PATCH] scsi: BusLogic: use %X for u32 sized integer rather than %lX To: Colin King , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210730095031.26981-1-colin.king@canonical.com> From: Khalid Aziz Message-ID: Date: Fri, 30 Jul 2021 15:57:16 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210730095031.26981-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/30/21 3:50 AM, Colin King wrote: > From: Colin Ian King > > An earlier fix changed the print format specifier for adapter->bios_addr > to use %lX however the integer is a u32 so the fix was wrong. Fix this > by using the correct %X format specifier. > > Addresses-Coverity: ("Invalid type in argument") > Fixes: 43622697117c ("scsi: BusLogic: use %lX for unsigned long rather than %X") > Signed-off-by: Colin Ian King > --- > drivers/scsi/BusLogic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c > index adddcd589941..bd615db5c58c 100644 > --- a/drivers/scsi/BusLogic.c > +++ b/drivers/scsi/BusLogic.c > @@ -1711,7 +1711,7 @@ static bool __init blogic_reportconfig(struct blogic_adapter *adapter) > if (adapter->adapter_bus_type != BLOGIC_PCI_BUS) { > blogic_info(" DMA Channel: None, ", adapter); > if (adapter->bios_addr > 0) > - blogic_info("BIOS Address: 0x%lX, ", adapter, > + blogic_info("BIOS Address: 0x%X, ", adapter, > adapter->bios_addr); > else > blogic_info("BIOS Address: None, ", adapter); > Acked-by: Khalid Aziz