Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] net: phy: micrel: Fix detection of ksz87xx switch
To:     Steve Bennett <steveb@workware.net.au>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, andrew@lunn.ch, hkallweit1@gmail.com,
        linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org
References: <20210730105120.93743-1-steveb@workware.net.au>
 <20210730225750.98849-1-steveb@workware.net.au>
From:   Marek Vasut <marex@denx.de>
Message-ID: <932a0c80-db3c-77ac-6bbe-101804329e02@denx.de>
Date:   Sat, 31 Jul 2021 01:08:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20210730225750.98849-1-steveb@workware.net.au>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/31/21 12:57 AM, Steve Bennett wrote:
> The logic for discerning between KSZ8051 and KSZ87XX PHYs is incorrect
> such that the that KSZ87XX switch is not identified correctly.
> 
> ksz8051_ksz8795_match_phy_device() uses the parameter ksz_phy_id
> to discriminate whether it was called from ksz8051_match_phy_device()
> or from ksz8795_match_phy_device() but since PHY_ID_KSZ87XX is the
> same value as PHY_ID_KSZ8051, this doesn't work.
> 
> Instead use a bool to discriminate the caller.
> 
> Without this patch, the KSZ8795 switch port identifies as:
> 
> ksz8795-switch spi3.1 ade1 (uninitialized): PHY [dsa-0.1:03] driver [Generic PHY]
> 
> With the patch, it identifies correctly:
> 
> ksz8795-switch spi3.1 ade1 (uninitialized): PHY [dsa-0.1:03] driver [Micrel KSZ87XX Switch]
> 
> Fixes: 8b95599c55ed24b36cf4 ("net: phy: micrel: Discern KSZ8051 and KSZ8795 PHYs")
> Signed-off-by: Steve Bennett <steveb@workware.net.au>

Looks obviously correct to me, and yes, this reinstates behavior before 
V3 of the original patch. Thanks!

Reviewed-by: Marek Vasut <marex@denx.de>