Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <43dbe366ef396a81357c032ea62d8b9543678a3d.camel@intel.com>
Subject: Re: [PATCH v2] iommu/vt-d: Dump DMAR translation structure
From:   Kyung Min Park <kyung.min.park@intel.com>
To:     Joerg Roedel <joro@8bytes.org>
Cc:     iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
        baolu.lu@linux.intel.com, dwmw2@infradead.org, will@kernel.org,
        yian.chen@intel.com, sohil.mehta@intel.com,
        ravi.v.shankar@intel.com, ashok.raj@intel.com
Date:   Fri, 30 Jul 2021 16:51:02 -0700
In-Reply-To: <YP6pw9j8i3bGOb13@8bytes.org>
References: <20210722042453.10579-1-kyung.min.park@intel.com>
         <YP6pw9j8i3bGOb13@8bytes.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Joerg,

On Mon, 2021-07-26 at 14:25 +0200, Joerg Roedel wrote:
> On Wed, Jul 21, 2021 at 09:24:53PM -0700, Kyung Min Park wrote:
> > When the dmar translation fault happens, the kernel prints a single
> > line
> > fault reason with corresponding hexadecimal code defined in the
> > Intel VT-d
> > specification.
> > 
> > Currently, when user wants to debug the translation fault in
> > detail,
> > debugfs is used for dumping the dmar_translation_struct, which is
> > not
> > available when the kernel failed to boot.
> > 
> > Dump the DMAR translation structure, pagewalk the IO page table and
> > print
> > the page table entry when the fault happens.
> > 
> > Signed-off-by: Kyung Min Park <kyung.min.park@intel.com>
> 
> This is too much noise in dmesg for a single dmar fault. Please hide
> that additional debug information behind a debug kernel option for
> the
> VT-d driver.

Sure, let me change in the next version.