Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp32965pxv; Fri, 30 Jul 2021 17:48:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztFCxo8bL9kVoH4AUCuc4FD7FHTG1gOtWkhvgXgoA1tFWljdPh/UQtJTl71SKwbY5awhH3 X-Received: by 2002:a17:906:8152:: with SMTP id z18mr5524911ejw.419.1627692500507; Fri, 30 Jul 2021 17:48:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627692500; cv=none; d=google.com; s=arc-20160816; b=jo+hJ8GCjMiEDBea9SgGANLLNF5+rmdx7NwU3YONzzh0btkpJX+kgQ9x/2uxZp15QC dhPIRf2woR5BZvPembEI90UFxa+UdcVlM4/ct5R7F9Tw1jmga4jNps5jAYeGzo2bmmQE W/fgIzfUXNzvOJ6i8k3pAYFew5OAqeqFiPH0JQeb/+HrmwB2o7XKVR3qP4xA7K56Gi59 Y3AxSH9ssR/p7kIcY8KH7pvFXHA8sKwjdST6UXq6YPTvM0gI+DDgTfWLoQAFL4bBXu2e Wpp8O92Zlm0Q9Ogg2K5Bk6ePQpJqoPbzyfG/xeSDsL1T3RMJsBDiGcKGDbaqlt5T5NBP u4Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=B40DBV3Rowl5xAsPZuwUHENVpWlPK3pB8JKI7iireQg=; b=f+Only6xb6me+Vw+6H/9pHrcAZ15T5oSTLyaWyHgS9UBpU880po21wQ5mEMUUqd9Ul uoac6Lzj/InCObpQTooGYUDna8aKHL5ouZ7FK/WO06r+7LlWPvTNd8QqqajFfHaZ/75E 4u3H/COkuz/MYmMhT8mAkmUoa1GBWxvfyXHQ6gWROw+8AVT76IvJJelZzQx7uTc+kDn4 SmlpiIS73d10rP9v66xklfeCDWBjXtYvV07TjTlZi6i0XBrdlsT2Q8ZOSpeg8EMusUwk aO82UJ67AxtAwiL/PNj+P04V6UiQoHHmoaHlNw0VujZ40fJoHRKzVjeh94UW+/Xnk/YD QjOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HcZ0jAYD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u12si3351230edx.354.2021.07.30.17.47.49; Fri, 30 Jul 2021 17:48:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HcZ0jAYD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234382AbhGaAnE (ORCPT + 99 others); Fri, 30 Jul 2021 20:43:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:51290 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234326AbhGaAnD (ORCPT ); Fri, 30 Jul 2021 20:43:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 067AA60FED; Sat, 31 Jul 2021 00:42:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627692178; bh=sPuGl+L1sdMhNZK/fg1Tmc3r36KfKxRqsunJdIUimWw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HcZ0jAYDOWYePNYjE32BhhbV1DO76aUFx129ROMN5YtXrvNo1928acyqx85pVexu1 lhL1ur0K3CAv7GD/mwp9I26CHucFbCf7hPN6P7KpsvgB2f/ZSiAWTqRuFc5Z/cHhx2 lpz7mDt3sWZWaOR/JmdX0gx+ZFq1JOdHyZDSGW2tqhLdlEY7yIvus0DYyWCvz+gB/g izEUKS5BaM0IPVpDEJx0o5ohIMTeJkgVZ9iZnFmQ0j1s/A9Cl4nGmSaJb5i03TZys0 ERmI5EheTcG1rsrHivHRugQkTrY/7m6xs6HENEh3mog9/zFcnjvhw97osmnSkJKkkR pZcd5wowcV0eA== Date: Fri, 30 Jul 2021 17:42:56 -0700 From: Jaegeuk Kim To: Chao Yu Cc: Chao Yu , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH] f2fs: introduce nosmall_discard mount option Message-ID: References: <20210730100530.4401-1-chao@kernel.org> <1a540deb-4219-4000-2f8d-a72695f1dfde@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1a540deb-4219-4000-2f8d-a72695f1dfde@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/31, Chao Yu wrote: > On 2021/7/31 7:41, Chao Yu wrote: > > On 2021/7/31 2:28, Jaegeuk Kim wrote: > > > how about adding "discard_gran=[small|segment|section]", and keeping discard_map > > > in the small case only? And, I think we should set the section mode for zoned > > > device automatically. > > > > Yup, better, > > > > About the naming, it look discard_gran is not clear here, since there is another > > sysfs entry /sys/fs/f2fs//discard_granularity has the same name, and > > also semantics of newly added mount option is not only control the smallest discard > > size, but also indicate discard start offset should be aligned to segment or section. > > So how about using: "aligned_discard=[none|segment|section]" instead? > > Maybe: "aligned_discard=[block|segment|section]"? How about discard_unit? I feel that issuing discards in one of those unit indicate the offset. > > > > > Thanks, > > > > > > _______________________________________________ > > Linux-f2fs-devel mailing list > > Linux-f2fs-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > >