Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757089AbWK0GgB (ORCPT ); Mon, 27 Nov 2006 01:36:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757090AbWK0GgB (ORCPT ); Mon, 27 Nov 2006 01:36:01 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:45207 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1757088AbWK0GgB (ORCPT ); Mon, 27 Nov 2006 01:36:01 -0500 Date: Mon, 27 Nov 2006 06:35:58 +0000 From: Christoph Hellwig To: Akinobu Mita , linux-kernel@vger.kernel.org, Stephen Smalley , James Morris , viro@zeniv.linux.org.uk Subject: Re: [PATCH] selinux: fix dentry_open() error check Message-ID: <20061127063558.GA6688@infradead.org> Mail-Followup-To: Christoph Hellwig , Akinobu Mita , linux-kernel@vger.kernel.org, Stephen Smalley , James Morris , viro@zeniv.linux.org.uk References: <20061127061648.GA20065@APFDCB5C> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061127061648.GA20065@APFDCB5C> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 684 Lines: 15 On Mon, Nov 27, 2006 at 03:16:48PM +0900, Akinobu Mita wrote: > The return value of dentry_open() shoud be checked by IS_ERR(). first great work finding all these calling convetion mismatches. Do you have some tool to find these? I wonder whether we should have some form of sparse annotation to tell that a function returns these kinds of errors and we either need to check IS_ERR or returned it again a caller with the same attribute. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/