Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 31 Jul 2021 08:47:35 +0200
From:   Heiko Carstens <hca@linux.ibm.com>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Ilya Leoshkevich <iii@linux.ibm.com>,
        Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org,
        Sven Schnelle <svens@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>, linux-s390@vger.kernel.org
Subject: Re: [PATCH 1/2] ftrace: Introduce ftrace_need_init_nop()
Message-ID: <YQTyB5eeC0FvDm06@osiris>
References: <20210728212546.128248-1-iii@linux.ibm.com>
 <20210728212546.128248-2-iii@linux.ibm.com>
 <20210730220741.4da6fdf6@oasis.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210730220741.4da6fdf6@oasis.local.home>
Precedence: bulk

On Fri, Jul 30, 2021 at 10:07:41PM -0400, Steven Rostedt wrote:
> On Wed, 28 Jul 2021 23:25:45 +0200
> Ilya Leoshkevich <iii@linux.ibm.com> wrote:
> 
> > Implementing live patching on s390 requires each function's prologue to
> > contain a very special kind of nop, which gcc and clang don't generate.
> > However, the current code assumes that if CC_USING_NOP_MCOUNT is
> > defined, then whatever the compiler generates is good enough.
> > 
> > Move the CC_USING_NOP_MCOUNT check into the new ftrace_need_init_nop()
> > macro, that the architectures can override.
> > 
> > An alternative solution is to disable using -mnop-mcount in the
> > Makefile, however, this makes the build logic (even) more complicated
> > and forces the arch-specific code to deal with the useless __fentry__
> > symbol.
> > 
> > Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> 
> I'm fine with this patch, and also you taking it in via the s390 tree.
> 
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Thanks a lot!