Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1627710765.git.gayatri.kammela@intel.com> <41f013b885b19ee7362272bb646ddd8a46d09fbb.1627710766.git.gayatri.kammela@intel.com>
In-Reply-To: <41f013b885b19ee7362272bb646ddd8a46d09fbb.1627710766.git.gayatri.kammela@intel.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sat, 31 Jul 2021 11:43:31 +0300
Message-ID: <CAHp75VcX0Xg2iamrew4qvzo1765MaSnr2uQ3ZMksS=3YiSthZw@mail.gmail.com>
Subject: Re: [PATCH v6 5/5] platform/x86/intel: pmc/core: Add GBE Package C10
 fix for Alder Lake PCH
To:     Gayatri Kammela <gayatri.kammela@intel.com>
Cc:     Platform Driver <platform-driver-x86@vger.kernel.org>,
        Mark Gross <mgross@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        You-Sheng Yang <vicamo.yang@canonical.com>,
        "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>,
        "Box, David E" <david.e.box@intel.com>, chao.qin@intel.com,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Tamar Mashiah <tamar.mashiah@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rajat Jain <rajatja@google.com>,
        Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
        Alex Deucher <Alexander.Deucher@amd.com>, mlimonci@amd.com,
        "David E. Box" <david.e.box@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Jul 31, 2021 at 9:10 AM Gayatri Kammela
<gayatri.kammela@intel.com> wrote:

> Alder PCH uses the same Gigabit Ethernet (GBE) device as Tiger Lake PCH

Alder Lake

> which cannot achieve PC10 without ignoring the PMC GBE LTR. Add this
> work around for Alder Lake PCH as well.

...

>         /*
> -        * On TGL, due to a hardware limitation, the GBE LTR blocks PC10 when
> -        * a cable is attached. Tell the PMC to ignore it.
> +        * On TGL and ADL, due to a hardware limitation, the GBE LTR blocks PC10
> +        * when a cable is attached. Tell the PMC to ignore it.
>          */

TGL -> Tiger Lake
ADL -> Alder Lake

-- 
With Best Regards,
Andy Shevchenko