Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp363521pxy;
        Sat, 31 Jul 2021 09:36:19 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxclwBurZosA2XSE1CzYVC3K945yd0vlABQlALOCpzTeTif2jWKUiXI/XgH9oHo9HG/oTB5
X-Received: by 2002:a5d:83c4:: with SMTP id u4mr120355ior.21.1627749378836;
        Sat, 31 Jul 2021 09:36:18 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1627749378; cv=none;
        d=google.com; s=arc-20160816;
        b=gA0pOXUaEs8oCdFxge+CsAhnWi+GNlwwLCgP5TyxokRG+3zXnnm2BSoHiinFsVrTGu
         sNInJpFDu7G/f468NpsaRdx+LMs03GWI03rPJnakTPHwQULpmvt6d7/Ctyxeccjmekow
         bovEELYqhdtyzA7RGMr6cqj6/SbfCxPbsz58A1l831+HwwoW0DveLjXWqJisSLZoXtBY
         CWJKczBWCzXIpHGEKR8+rc4Yndmkf8L5rtL97bNPljdf6PHXKc8UKL+fT5VroxwrAAwE
         HDxr5uhDJdqnd9YCBh/KbADZi+qotDGTEw8FxXil1Zv/RFVrZWdMO0oE0mG7qifzmM9K
         mbbA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=FREpGVDLHCV92Qi+Gv6B4L/njCVAvRbNFGhqJZprBTk=;
        b=Byd3z0NZPHc8y0mXeCA5shR7Lg2Q7n4b2guj8RvwdUxdIx5a3Q3i/9LjT5Q8BnKQ3J
         oAdYJrdRvompKZZ6QAByVTLxCZQyPIb9vk7EbzULPKuqQIuGzW3KC1gljL8cuu+/vDhq
         g0eMXwFpAELjv/nbcfgJdeWPQ6IbI381k8N8D464+kyD8s8i8g8wC8Jg0ZoWLenTJCJD
         OeHg44MjiaN3wj8lQbmuX86ax8O5owP3Rb9fITzSrV3A9H/QIXTXUyDh5PBCOX82AyTv
         G2vpUnASSw/5ykOHt+6lgGGngmag4laVdcvSqPsXh7e625nIk/6IWmfGC/6Q+Anj4HOB
         rqDQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cOI+2Rsr;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id g6si5512904ilf.57.2021.07.31.09.36.07;
        Sat, 31 Jul 2021 09:36:18 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cOI+2Rsr;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229724AbhGaQd7 (ORCPT <rfc822;linux.whf@gmail.com> + 99 others);
        Sat, 31 Jul 2021 12:33:59 -0400
Received: from mail.kernel.org ([198.145.29.99]:39602 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229449AbhGaQd7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 31 Jul 2021 12:33:59 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id 4DC3E60F13;
        Sat, 31 Jul 2021 16:33:52 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1627749232;
        bh=BOPpUSjxDz00r/FRJaG8mxlK8DItXDs1H8BlKV/FtI8=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=cOI+2RsrQQS4FyIwRgtRa9xBkb/42RdGz4DeY59M3GPww/TjftQ6LEIBBdENRiIxB
         uMZXCwrJZCoAbV39tXQHD7dlgkojYZJpW0gKWvDEFmVIbamuqD2YoF4WVan8kYapWh
         ar5/meLJYdjFWPfDL5ebMx9/D2CaVt3WTqDVwBYSO1Nle2/03d4y7JN1uJ/JF7U5YS
         c4Tc4vSEdc2ZYFM2PfQ6Xl/ieqbTJTsf+kLUie9mTSrUoHJ0oRJfiCMHmKfeU8MHLv
         3n8KOev3mYGpr+JtmGMz98p1dWOBO8eulPM1yBWFibsQh0NcqvzBT4f8a/yyMeJ39S
         b9LUcta5G14Uw==
Date:   Sat, 31 Jul 2021 09:33:51 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Jordy Zomer <jordy@pwning.systems>
Cc:     netdev@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Chas Williams <3chas3@gmail.com>,
        linux-atm-general@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atm: [nicstar] make drain_scq explicitly unsigned
Message-ID: <20210731093351.39c0e305@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20210731085429.510245-1-jordy@pwning.systems>
References: <20210731085429.510245-1-jordy@pwning.systems>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 31 Jul 2021 10:54:28 +0200 Jordy Zomer wrote:
> The drain_scq function used to take a signed integer as a pos parameter.
> The only caller of this function passes an unsigned integer to it.
> Therefore to make it obviously safe, let's just make this an unsgined
> integer as this is used in pointer arithmetics.
> 
> Signed-off-by: Jordy Zomer <jordy@pwning.systems>

Does not build.