Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 1 Aug 2021 15:04:03 +1000 (AEST)
From:   Finn Thain <fthain@linux-m68k.org>
To:     =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, kernel@pengutronix.de,
        linux-m68k@lists.linux-m68k.org
Subject: Re: [PATCH v2 1/4] nubus: Simplify check in remove callback
In-Reply-To: <20210730191035.1455248-2-u.kleine-koenig@pengutronix.de>
Message-ID: <dd248ad3-87b-ead8-957d-aea36cb01058@linux-m68k.org>
References: <20210730191035.1455248-1-u.kleine-koenig@pengutronix.de> <20210730191035.1455248-2-u.kleine-koenig@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="-1463811774-1980221512-1627794129=:27"
Content-ID: <f0cf4098-5fe6-2ba5-457a-fd1b6bf4b24c@nippy.intranet>
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

---1463811774-1980221512-1627794129=:27
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Content-ID: <422deda6-11f-a1c8-5510-7123c82751b8@nippy.intranet>

On Fri, 30 Jul 2021, Uwe Kleine-K=C3=B6nig wrote:

> The driver core only calls a remove callback when the device was
> successfully bound (aka probed) before. So dev->driver is never NULL and
> the respective check can just be dropped.
>=20
> Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>

Acked-by: Finn Thain <fthain@linux-m68k.org>

BTW, aside from nubus, zorro and superhyway you can find the same pattern
in many other busses. You may want to patch the following methods too.

acpi_device_remove
apr_device_remove
ccwgroup_remove
gio_device_remove
hid_device_remove=20
ibmebus_bus_device_remove
macio_device_remove
memstick_device_remove
ntb_remove
pci_device_remove
pnp_device_remove
ps3_system_bus_remove
rio_device_remove
slim_device_remove
soundbus_device_remove
ssb_device_remove
tifm_device_remove
vdpa_dev_remove
vmbus_remove

> ---
>  drivers/nubus/bus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/nubus/bus.c b/drivers/nubus/bus.c
> index d9d04f27f89b..17fad660032c 100644
> --- a/drivers/nubus/bus.c
> +++ b/drivers/nubus/bus.c
> @@ -33,7 +33,7 @@ static void nubus_device_remove(struct device *dev)
>  {
>  =09struct nubus_driver *ndrv =3D to_nubus_driver(dev->driver);
> =20
> -=09if (dev->driver && ndrv->remove)
> +=09if (ndrv->remove)
>  =09=09ndrv->remove(to_nubus_board(dev));
>  }
> =20
>=20
---1463811774-1980221512-1627794129=:27--