Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp818516pxy; Sun, 1 Aug 2021 03:18:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxOwTJIbJGZjAOKlGRzG4cZZHv6kt3LBHqEN/knpT5chqMBQ5W2m8xJ4WS78avRZw/DYnOr X-Received: by 2002:a17:906:410a:: with SMTP id j10mr10936346ejk.167.1627813090221; Sun, 01 Aug 2021 03:18:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627813090; cv=none; d=google.com; s=arc-20160816; b=voA/RvCkXBZvUQj7sNMNbw2Sins9xxXMtCm9ytSLqanDinMjYoi+3fh0jSrz1tW2uo ZXbQ6UgVDKwo+V+b8WXsguOnSAZ+xExxrhC6yWCs0QhPJGsd/efhXWjWyL4JGFX5XPpK glGy1zB3+aBh2oST4DIz9658xfN8nsP/cu4pXzZGr2oPqDTMtRQ4xClA+ZKADKP7b0PA Y64PRJN6n0dwTiL0beiItGefWN60fYbpOjK+7xd8VhuPxq0ZMlc0mjwi9r3K5pd3i4Ua xYK45WKlgDFq5mRv21udsWB9WLjSGyE6wzBlWlJf9+Vu01J3TijM5cOPgkSCzcyOnEi/ Em6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=C4raq+WAH0CPdHjR9ROGWw0kYwJKyeCZq/6DLCT6kBU=; b=E5zJPzmqhCBHlOoSUu1vReTjlDDJT772DCyyrARxNRxmsbb6QRx8I5GYDT4k+Oj58/ SxZowofDkcsHENNNG26UKPlpSyPLX7TJ6QPqptHMsRyChEqgtT3e8yB+A56Ie0qk/8Fe SMaL+0I6KUAycxnMhK4/Wyad0IH1pxiMN/RF734s5K58YeJ8v1TBEnrIskHxsM8kwOAo gd7p877L8pgLtKkpCVviKxSMAmWOcugV2X4CtgEZ85X1UmKBXl8X8Qx/BN1+gzp28WbV tLM2xNvwEd3NCx8D5xtmV+7l0RW0l7zxwkFlout9FOcqdeW/9YCRucN0LKSyqVrvLTZY zikw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j5si6862858ejk.119.2021.08.01.03.17.44; Sun, 01 Aug 2021 03:18:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231621AbhHAKPv (ORCPT + 99 others); Sun, 1 Aug 2021 06:15:51 -0400 Received: from mail.netfilter.org ([217.70.188.207]:47736 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231473AbhHAKPu (ORCPT ); Sun, 1 Aug 2021 06:15:50 -0400 Received: from netfilter.org (bl11-146-165.dsl.telepac.pt [85.244.146.165]) by mail.netfilter.org (Postfix) with ESMTPSA id D6CA060033; Sun, 1 Aug 2021 12:15:07 +0200 (CEST) Date: Sun, 1 Aug 2021 12:15:37 +0200 From: Pablo Neira Ayuso To: Yajun Deng Cc: kadlec@netfilter.org, fw@strlen.de, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] netfilter: nf_conntrack_bridge: Fix memory leak when error Message-ID: <20210801101537.GA20629@salvia> References: <20210729082021.14407-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210729082021.14407-1-yajun.deng@linux.dev> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 29, 2021 at 04:20:21PM +0800, Yajun Deng wrote: > It should be added kfree_skb_list() when err is not equal to zero > in nf_br_ip_fragment(). Applied, thanks.