Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp1055353pxy; Sun, 1 Aug 2021 10:54:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAQfyCnRqC+YIRwAwkkwdQMNCd7d22N0m8PRlRYAFXxBQEJXTFEw2bRT798d9sTTDQy/Gi X-Received: by 2002:a6b:c90f:: with SMTP id z15mr3248531iof.183.1627840460415; Sun, 01 Aug 2021 10:54:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627840460; cv=none; d=google.com; s=arc-20160816; b=btLiIOJL8ZSERhKZ8ZFPH6PkTW/5K+yypeEDqW4xLL2cTXK2lnZADqtRSMHD+KkdXI x7neAQVx6qqUpGZZMa80WZYkcJUAvzCnA0Ci8ODr+Uur0+qFJ3ccoF3Z296s+4rs0M6G ORfcqErAz7z+EpT520WN5quz0O4CLeTnPi1pHI1aITt4foEowRP9s1386B5OYBMuH+ae G4t2mnJJnAcAEPv2Ail2nJ01nmMkaskOntvYsDVIWjug6l7o+kZ1zaCFJ8EItiQ0vSIt yrLwCXc1BEC/RgEaQZlG0sxj4sSXZeoZevXjQ7+DBR4czf7mb4dd3mkW4BfwitXG4O61 /Umw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=u30HY0qoSu/Cg3EmHI0sLuPTfYYyEpN2Y4AfpivAtHc=; b=TeXnBZpMuVWMBtA+S5X1yW6ApluIntFgTY7xK+6VrP+56puLmwqUYrob6HUFZXsC+u FcaBHqnnRsegrGGfvwjH83RloJ1DA2xIRST5b6dPuCe3JPnpquK2hJDVl3dRJGKTUAja Ty9580q9wPIhSko42kiKlwc294Fj2Lr3/MH8DvB72VR9SIahpTTDfn9jsU36tpGWBNUw yO9qQYpGeVhwx+Up5R7+3oZ778c6/ztQdQ33lfZvsoCAa5fr0Lmc7OYCkmF7UzrS7Phl EObEcs4hWqX+/7xWe0nr4Igm4iQuJ498gOrRzENudAS4TsRTtyC+hVWMWh6DInHZryVX EB5w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d21si9872447jam.9.2021.08.01.10.53.56; Sun, 01 Aug 2021 10:54:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230154AbhHARvE (ORCPT + 99 others); Sun, 1 Aug 2021 13:51:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229851AbhHARvC (ORCPT ); Sun, 1 Aug 2021 13:51:02 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84D3DC06175F for ; Sun, 1 Aug 2021 10:50:54 -0700 (PDT) Received: from martin by viti.kaiser.cx with local (Exim 4.89) (envelope-from ) id 1mAFbt-0002fK-Te; Sun, 01 Aug 2021 19:50:49 +0200 Date: Sun, 1 Aug 2021 19:50:49 +0200 From: Martin Kaiser To: Larry Finger Cc: Phillip Potter , Greg KH , Dan Carpenter , Linux Kernel Mailing List , linux-staging@lists.linux.dev, Fabio Aiuto Subject: Re: [PATCH v4 0/6] staging: r8188eu: add newer/better RTL8188eu driver Message-ID: <20210801175049.eubghjzmhx25ol73@viti.kaiser.cx> References: <20210727232219.2948-1-phil@philpotter.co.uk> <20210728074605.pp5rs4c65tofnqot@viti.kaiser.cx> <20210729133730.lnxqzawnvksp4skg@viti.kaiser.cx> <1d687d5f-d514-655a-f8bf-a5bac321affb@lwfinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1d687d5f-d514-655a-f8bf-a5bac321affb@lwfinger.net> User-Agent: NeoMutt/20170113 (1.7.2) Sender: Martin Kaiser Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Greg and Larry, thanks for your responses. Thus wrote Larry Finger (Larry.Finger@lwfinger.net): > I do see this driver being cleaned up to the point that it transitions to mainline. > It is not clear to me that it would fit into the rtlwifi framework. It > probably could use the USB driver there, but unlikely to use a lot more of > that code. Ok, that clarifies that path forward. I wasn't sure if a standalone (non-rtlwifi) driver is acceptable at all. > I will certainly be on the lookout for conflicts with the rtlwifi and > rtl8xxxu, indeed the whole drivers/net/wireless/realtek/, code as the > cleanup proceeds. At the moment, the driver (like the old one) can be compiled only as a module. I guess that's because of name conflicts between realtek drivers that originated from the same codebase. It seems that we'll have to rename some functions along the way. Thanks, Martin