Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 1 Aug 2021 20:52:42 -0700 (PDT)
From:   David Rientjes <rientjes@google.com>
To:     Luigi Rizzo <lrizzo@google.com>
cc:     Will Deacon <will@kernel.org>, linux-kernel@vger.kernel.org,
        Joerg Roedel <joro@8bytes.org>, rizzo.unipi@gmail.com,
        Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH] amd/iommu: fix logic bug in
 amd_iommu_report_page_fault()
In-Reply-To: <20210731192637.3653796-1-lrizzo@google.com>
Message-ID: <6d9bf4fc-4956-70fd-6d80-2b0ee92a571@google.com>
References: <20210731192637.3653796-1-lrizzo@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sat, 31 Jul 2021, Luigi Rizzo wrote:

> amd_iommu_report_page_fault() has two print paths, depending on whether or
> not it can find a pci device. But the code erroneously enters the second
> path if the rate limiter in the first path triggers:
>   if (dev_data && ratelimit(A)) { A; } else if (ratelimit(B)) { B; }
> The correct code should be
>   if (dev_data) { if (ratelimit(A)) { A;} } else if (ratelimit(B)) { B; }
> 
> Signed-off-by: Luigi Rizzo <lrizzo@google.com>

Acked-by: David Rientjes <rientjes@google.com>

This would be very helpful so we don't erroneously classify these KERN_ERR 
messages as dangerous.