Received: by 2002:a05:6a10:c7c6:0:0:0:0 with SMTP id h6csp1364447pxy; Sun, 1 Aug 2021 22:53:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMkZulCpVCUxV7zo3wN+jtAQ8xeYzUEOZXHFpRwAmMfI3NLjprdBlo3Vgv+7foorHXHHMc X-Received: by 2002:a5d:87cc:: with SMTP id q12mr1417992ios.131.1627883595313; Sun, 01 Aug 2021 22:53:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627883595; cv=none; d=google.com; s=arc-20160816; b=T0TgvYZOJ0eQwhS7nZeoCFoPlTKD9hPIYKitcIfq5iWQd1WMnq7HGAXLgF3hodC/IW LAB5jLZrNOpM3J/vR5GlaaTpVn7MBxAZ66NqjRynYkS/ozVN1S5tyQTXiWHwv9LGDU1/ 3XAkZrD+peX1GVm0PlJVPzMGxfUWb6Vi3uRCSmenaugflPiJdVc6nKoun7iURxAiuave ycJC+wJGeCmR70CD2OGFf1S+L7zdAo5Ma88IhyeH5pDjQIrq1r6K58T9+ChbqFr3DhPB qlzdoFyTemKqKhvLPF4FX5bx5iXZx3F5hihazWzQGtqXjwN1S/FH6f5CURfaSPSzmyfR tQxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=ysI5MYxa+yRx1/xsKQcxyXNHdjal1qtXVK5Ng1WKmKo=; b=nLG5/ImqaBLS+DDP8EySU9hmgijOYkGYuwzhX5c5M60UWww9+XKwZ9C0i7p4p6UI+Z zonP28wg4umCv5tzvDdp7mLOD+i3D3/Sk9/u+r/yNuBLhVIh4X3l/HbF7B/GZ38hne+v Vy2G5UFiB09f9uk+8s1kCdEX2PHZ8tuMkwcv1ry4zlB2KSkOPosYySa+XdPCVYk00e2U r1oMHKV226Sru8OCbDrG7TexM1ndmmM4gnEkibrNqw+uhePjnbPiJlrqM2kZg0kBNLJV IDXhtIS3WJCffgo3lLV0kTgGonSpb7sbBtlZddloJHcszE/tjgvbLykL0P1xKczGOktK UsLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d2si10443487iow.58.2021.08.01.22.53.03; Sun, 01 Aug 2021 22:53:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230297AbhHBFvd (ORCPT + 99 others); Mon, 2 Aug 2021 01:51:33 -0400 Received: from mailout2.secunet.com ([62.96.220.49]:60090 "EHLO mailout2.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229495AbhHBFvc (ORCPT ); Mon, 2 Aug 2021 01:51:32 -0400 Received: from cas-essen-01.secunet.de (unknown [10.53.40.201]) by mailout2.secunet.com (Postfix) with ESMTP id 9734E800051; Mon, 2 Aug 2021 07:51:21 +0200 (CEST) Received: from mbx-essen-01.secunet.de (10.53.40.197) by cas-essen-01.secunet.de (10.53.40.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 2 Aug 2021 07:51:21 +0200 Received: from gauss2.secunet.de (10.182.7.193) by mbx-essen-01.secunet.de (10.53.40.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 2 Aug 2021 07:51:21 +0200 Received: by gauss2.secunet.de (Postfix, from userid 1000) id 0730A31804EF; Mon, 2 Aug 2021 07:51:20 +0200 (CEST) Date: Mon, 2 Aug 2021 07:51:20 +0200 From: Steffen Klassert To: Pavel Skripkin CC: , , , , , Subject: Re: [PATCH next] net: xfrm: fix shift-out-of-bounce Message-ID: <20210802055120.GT893739@gauss3.secunet.de> References: <20210728163818.10744-1-paskripkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210728163818.10744-1-paskripkin@gmail.com> X-ClientProxiedBy: cas-essen-02.secunet.de (10.53.40.202) To mbx-essen-01.secunet.de (10.53.40.197) X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 28, 2021 at 07:38:18PM +0300, Pavel Skripkin wrote: > We need to check up->dirmask to avoid shift-out-of-bounce bug, > since up->dirmask comes from userspace. > > Also, added XFRM_USERPOLICY_DIRMASK_MAX constant to uapi to inform > user-space that up->dirmask has maximum possible value > > Fixes: 2d151d39073a ("xfrm: Add possibility to set the default to block if we have no policy") > Reported-and-tested-by: syzbot+9cd5837a045bbee5b810@syzkaller.appspotmail.com > Signed-off-by: Pavel Skripkin Applied, thanks a lot!