Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 2 Aug 2021 08:52:24 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Finn Thain <fthain@linux-m68k.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
        kernel@pengutronix.de
Subject: Re: [PATCH v2 1/4] nubus: Simplify check in remove callback
Message-ID: <20210802065224.n2tarfx6hzfamdyp@pengutronix.de>
References: <20210730191035.1455248-1-u.kleine-koenig@pengutronix.de>
 <20210730191035.1455248-2-u.kleine-koenig@pengutronix.de>
 <dd248ad3-87b-ead8-957d-aea36cb01058@linux-m68k.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="5fojauxrhuxtr35u"
Content-Disposition: inline
In-Reply-To: <dd248ad3-87b-ead8-957d-aea36cb01058@linux-m68k.org>
Precedence: bulk


--5fojauxrhuxtr35u
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Finn,

On Sun, Aug 01, 2021 at 03:04:03PM +1000, Finn Thain wrote:
> On Fri, 30 Jul 2021, Uwe Kleine-K=F6nig wrote:
>=20
> > The driver core only calls a remove callback when the device was
> > successfully bound (aka probed) before. So dev->driver is never NULL and
> > the respective check can just be dropped.
> >=20
> > Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
>=20
> Acked-by: Finn Thain <fthain@linux-m68k.org>
>=20
> BTW, aside from nubus, zorro and superhyway you can find the same pattern
> in many other busses. You may want to patch the following methods too.
>=20
> acpi_device_remove
> apr_device_remove
> ccwgroup_remove
> gio_device_remove
> hid_device_remove=20
> ibmebus_bus_device_remove
> macio_device_remove
> memstick_device_remove
> ntb_remove
> pci_device_remove
> pnp_device_remove
> ps3_system_bus_remove
> rio_device_remove
> slim_device_remove
> soundbus_device_remove
> ssb_device_remove
> tifm_device_remove
> vdpa_dev_remove
> vmbus_remove

Did you find these by hand? Or using a coccinelle match?

Anyhow, thanks for the list, I'll add it to my todo list but if you're
motivated don't consider these cleanups as my property. (Please Cc: me
though to prevent duplicated effort.)

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--5fojauxrhuxtr35u
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmEHliUACgkQwfwUeK3K
7AmrvAf9Gj/ycetiy4CpnD54L0WCnwWHBfM5j7ugv1yT8W21V/oUlqs7OjPF16i5
gEPGZ4tYdiOd89M++P7zgfVWSnD3XDpdRfP9hgJu30KrUyUz8hQi3Y3caGaSzx3Q
aTP4I3v94qeRRR79t0ckMqw/wnCH+UsdODv0dUxfChw9udvY9XufHfov3WSiL0ep
e3CJn3im7m+znXugiQchPaO8DZ5anT/rW0Y9gvCMqeh0vlO4lnM5ut5p7iYh275E
rHpQb5eoehumjDLuP5o8wG/U9O0caRG64Usgaq+9oCrBvL7w1GumI2B9WeaTezdO
NNn9NnWx9YLgUnrN0gEdujSGYHqFFQ==
=iJUA
-----END PGP SIGNATURE-----

--5fojauxrhuxtr35u--