Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758209AbWK0Nul (ORCPT ); Mon, 27 Nov 2006 08:50:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758214AbWK0Nul (ORCPT ); Mon, 27 Nov 2006 08:50:41 -0500 Received: from mgw-ext11.nokia.com ([131.228.20.170]:4787 "EHLO mgw-ext11.nokia.com") by vger.kernel.org with ESMTP id S1758209AbWK0Nuk (ORCPT ); Mon, 27 Nov 2006 08:50:40 -0500 Message-ID: <456AEC16.3010009@indt.org.br> Date: Mon, 27 Nov 2006 09:45:58 -0400 From: Anderson Briglia User-Agent: Icedove 1.5.0.7 (X11/20061013) MIME-Version: 1.0 To: ext Pierre Ossman CC: "Linux-omap-open-source@linux.omap.com" , Russell King , Tony Lindgren , "Aguiar Carlos (EXT-INdT/Manaus)" , ext David Brownell , "Lizardo Anderson (EXT-INdT/Manaus)" , linux-kernel@vger.kernel.org Subject: Re: [patch 3/5] [RFC] Add MMC Password Protection (lock/unlock) support V7: mmc_lock_unlock.diff References: <4564640B.1070004@indt.org.br> <45680308.4040809@drzeus.cx> In-Reply-To: <45680308.4040809@drzeus.cx> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 27 Nov 2006 13:41:57.0510 (UTC) FILETIME=[CEC19260:01C71229] X-Nokia-AV: Clean Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 824 Lines: 30 ext Pierre Ossman wrote: > Anderson Briglia wrote: >> @@ -244,5 +244,13 @@ struct _mmc_csd { >> #define SD_BUS_WIDTH_1 0 >> #define SD_BUS_WIDTH_4 2 >> >> +/* >> + * MMC_LOCK_UNLOCK modes >> + */ >> +#define MMC_LOCK_MODE_ERASE (1<<3) >> +#define MMC_LOCK_MODE_UNLOCK (0<<2) >> +#define MMC_LOCK_MODE_CLR_PWD (1<<1) >> +#define MMC_LOCK_MODE_SET_PWD (1<<0) >> + >> #endif /* MMC_MMC_PROTOCOL_H */ >> > > This definition makes them look like bits, which is not how they are used. How can I improve this? Defining using integers directly? > > Rgds > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/