Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     Larry Finger <Larry.Finger@lwfinger.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     LKML <linux-kernel@vger.kernel.org>, linux-staging@lists.linux.dev
Subject: Re: kernel BUG in new r8188eu
Date:   Mon, 02 Aug 2021 13:45:06 +0200
Message-ID: <147993920.vpeT8VCmXh@localhost.localdomain>
In-Reply-To: <YQfKohnSRWHjlht6@kroah.com>
References: <80042e9f-6811-38f3-010b-1c0951ba88db@lwfinger.net> <cef19337-5ff3-c0cd-33ef-4f9990bcd4ec@lwfinger.net> <YQfKohnSRWHjlht6@kroah.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

Hi Greg,

On Monday, August 2, 2021 12:36:18 PM CEST Greg Kroah-Hartman wrote:
> On Sun, Aug 01, 2021 at 03:15:52PM -0500, Larry Finger wrote:
> > On 8/1/21 1:31 AM, Greg Kroah-Hartman wrote:
> > > I am worried that my "remove the wrapper" logic got something wrong
> > > here, so if you could test the revert of that, I would appreciate it.
> > > 
> > > I think I need to go buy one of these devices so I can test cleanups
> > > locally...
> > 
> > The bad commit was 9ff1cc4ef80e ("staging: r8188eu: remove rtw_buf_free()
> > function").
> > 
> > Looking at it, the only difference between the original wrapper and the 
new
> > code is that the wrapper zeros the len variable before the kfree() call, 
but
> > making that change did not help. Reverting that patch restores the old
> > behavior.
> 
> Ah, doh, that was my fault, sorry, that patch was incorrect (odd git id,
> don't know where that came from, it's a different id in my tree.)  Let
> me revert this commit and then will redo it correctly.

The commit to revert should be c7e88ecbe328.

> 
> thanks for finding this.
> 
> > There are lots of these on Ebay from $2.47 up with free shipping!
> 
> Any hints on the name for how to figure out which devices are supported
> by this driver?

The following link points to a device that seems to be supported by this 
driver. It is just $4.99, but I'm not sure whether or not they ship to Europe 
(I suppose you're here):

https://www.amazon.com/gp/product/B00L28AN88/ref=ox_sc_act_title_1
 
About this item: 
* Chipset:RTL8188EU 
* Standard: IEEE 802.11n,IEEE 802.11g, IEEE 802.11b 
* Supports 64/128 bit WEP, WPA encryption 

Otherwise, I think that the following uses the same chip as the above. 
However, it costs a little more and, above all else, I'm not really sure if it 
works with r8188eu, since they write that the chip is a Realtek RTL8188EUS 
(please note that final "EUS"):

https://www.amazon.it/Asus-USB-N10-NANO-N150-compatibile/dp/B081758CWC/
ref=sr_1_1

Thanks,

Fabio


> thanks,
> 
> greg k-h